Update the analysis server integration tests to always run on the analysis driver.

pkg/analysis_server/test/integration/analysis/error_test.dart

Index: pkg/analysis_server/test/integration/analysis/error_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/error_test.dart b/pkg/analysis_server/test/integration/analysis/error_test.dart
index 3d11f4e571e8a549082a8f7795b4e6538d64c871..69481d3d6a172b6037a1e979e9b4abe49feb93c0 100644
--- a/pkg/analysis_server/test/integration/analysis/error_test.dart
+++ b/pkg/analysis_server/test/integration/analysis/error_test.dart
@@ -14,11 +14,11 @@ main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(AnalysisErrorIntegrationTest);
     defineReflectiveTests(NoAnalysisErrorsIntegrationTest);
-    defineReflectiveTests(NoAnalysisErrorsIntegrationTest_Driver);
   });
 }
 
-class AbstractAnalysisErrorIntegrationTest
+@reflectiveTest
+class AnalysisErrorIntegrationTest
     extends AbstractAnalysisServerIntegrationTest {
   test_detect_simple_error() {
     String pathname = sourcePath('test.dart');
@@ -71,6 +71,8 @@ abstract class C extends B {
             "The class 'C' can't be used as a mixin because it references 'super'."));
   }
 
+  // We see errors here with the new driver (#28870).

[Brian Wilkerson, 2017/02/23 17:58:18]

Move comments like this inside the method (or at least after the annotation,
otherwise sort will eventually cause the comment to move away from the method
and we'll loose this information.

+  @failingTest
   test_super_mixins_enabled() async {
     String pathname = sourcePath('test.dart');
     writeFile(
@@ -99,10 +101,6 @@ abstract class C extends B {
 }
 
 @reflectiveTest
-class AnalysisErrorIntegrationTest
-    extends AbstractAnalysisErrorIntegrationTest {}
-
-@reflectiveTest
 class NoAnalysisErrorsIntegrationTest
     extends AbstractAnalysisServerIntegrationTest {
   @override
@@ -111,10 +109,11 @@ class NoAnalysisErrorsIntegrationTest
       server.start(
           checked: checked,
           diagnosticPort: diagnosticPort,
-          enableNewAnalysisDriver: enableNewAnalysisDriver,
           noErrorNotification: true,
           servicesPort: servicesPort);
 
+  // Errors are reported with noErrorNotification: true (#28869).
+  @failingTest
   test_detect_simple_error() {
     String pathname = sourcePath('test.dart');
     writeFile(
@@ -129,16 +128,3 @@ main() {
     });
   }
 }
-
-@reflectiveTest
-class NoAnalysisErrorsIntegrationTest_Driver
-    extends NoAnalysisErrorsIntegrationTest {
-  @override
-  bool get enableNewAnalysisDriver => true;
-
-  @failingTest
-  @override
-  test_detect_simple_error() {
-    return super.test_detect_simple_error();
-  }
-}