Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: pkg/analysis_server/test/integration/analysis/analysis_options_test.dart

Issue 2710193002: Update the analysis server integration tests to always run on the analysis driver. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/analysis_options_test.dart b/pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
index 3216977f944b100eb3935687865bcc60315f6d09..49a165a24cece79aa022ec03fc13958fe98f8251 100644
--- a/pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
+++ b/pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
@@ -12,13 +12,16 @@ import '../integration_tests.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(OptionsIntegrationTest);
- defineReflectiveTests(OptionsIntegrationTest_Driver);
});
}
-class AbstractOptionsIntegrationTest
- extends AbstractAnalysisServerIntegrationTest {
+@reflectiveTest
+class OptionsIntegrationTest extends AbstractAnalysisServerIntegrationTest {
+ @failingTest
test_option_warning_newOptionFile() async {
+ // Test timed out after 30 seconds (#28868).
+ fail('Test timed out');
+
String options = sourcePath(AnalysisEngine.ANALYSIS_OPTIONS_YAML_FILE);
writeFile(
options,
@@ -45,7 +48,11 @@ linter:
expect(error.location.startColumn, 7);
}
+ @failingTest
test_option_warning_oldOptionFile() async {
+ // Test timed out after 30 seconds (#28868).
+ fail('Test timed out');
+
String options = sourcePath(AnalysisEngine.ANALYSIS_OPTIONS_FILE);
writeFile(
options,
@@ -72,26 +79,3 @@ linter:
expect(error.location.startColumn, 7);
}
}
-
-@reflectiveTest
-class OptionsIntegrationTest extends AbstractOptionsIntegrationTest {}
-
-@reflectiveTest
-class OptionsIntegrationTest_Driver extends AbstractOptionsIntegrationTest {
- @override
- bool get enableNewAnalysisDriver => true;
-
- @failingTest
- test_option_warning_newOptionFile() async {
- // TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
- //return super.test_option_warning_newOptionFile();
- fail('Test timed out');
- }
-
- @failingTest
- test_option_warning_oldOptionFile() async {
- // TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
- //return super.test_option_warning_oldOptionFile();
- fail('Test timed out');
- }
-}

Powered by Google App Engine
This is Rietveld 408576698