ozone: drm: Add more debug details when dmabuf mmap fails.

ozone: drm: Add more details when dmabuf mmap fails.

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds more information when dmabuf mmap fails in the crash report
that is uploaded.
It adds the values of the parameters passed to mmap, the validity of the fd
passed to mmap, the last errno set, and the logical size of the buffer.

Additionally, while we used to always report mmap failing as out of memory,
after this CL we'll differentiate based on the last system error set.

BUG=629521
Review-Url: https://codereview.chromium.org/2710183005
Cr-Commit-Position: refs/heads/master@{#453226}
Committed: https://chromium.googlesource.com/chromium/src/+/7288c33cfa94a7d45a98eb3cdb4dd5ef11da9d3b

[Daniele Castagna, 2017-02-23 22:45:53]

Description was changed from

==========
ozone: drm: Add more details when dmabuf mmap fails.

While native GPU memory buffers have been enabled we noticed many crashes
reporting mmap failing.

This CL adds more information when dmabuf mmap fails and a crash report is
uploaded.
It adds the values of the parameters passed to mmap, the validity of the fd
passed to mmap, the last errno set, and the logical size of the buffer.

Additionally, while we used to always report mmap failing as out of memory,
after this CL we'll differentiate based on the last system error set.

BUG=629521
==========

to

==========
ozone: drm: Add more details when dmabuf mmap fails.

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds more information when dmabuf mmap fails in the crash report
that is uploaded.
It adds the values of the parameters passed to mmap, the validity of the fd
passed to mmap, the last errno set, and the logical size of the buffer.

Additionally, while we used to always report mmap failing as out of memory,
after this CL we'll differentiate based on the last system error set.

BUG=629521
==========

[Daniele Castagna, 2017-02-23 22:46:00]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2017-02-23 22:46:27]

dcastagna@chromium.org changed reviewers:
+ dongseong.hwang@chromium.org, marcheu@chromium.org, reveman@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:46:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:56:27]

Dry run: This issue passed the CQ dry run.

[reveman, 2017-02-24 00:46:19]

lgtm % nits

https://codereview.chromium.org/2710183005/diff/20001/ui/ozone/platform/drm/c...
File ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc (right):

https://codereview.chromium.org/2710183005/diff/20001/ui/ozone/platform/drm/c...
ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc:85:
logging::SystemErrorCode mmap_error = logging::GetLastSystemErrorCode();
nit: please add a TODO comment with a bug reference here for removing this
temporary diagnostics when we've been able to determine what's causing these
failures

https://codereview.chromium.org/2710183005/diff/20001/ui/ozone/platform/drm/c...
ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc:98: } else {
nit: remove else as base::TerminateBecauseOutOfMemory will never return

[Daniele Castagna, 2017-02-24 01:18:20]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org, rsesek@chromium.org

[Daniele Castagna, 2017-02-24 01:18:21]

Tnx for the review.

Adding owners:
- dnicoara@ for ui/ozone/*
- rsesek@ for chrome/common/crash_keys.cc

https://codereview.chromium.org/2710183005/diff/20001/ui/ozone/platform/drm/c...
File ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc (right):

https://codereview.chromium.org/2710183005/diff/20001/ui/ozone/platform/drm/c...
ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc:85:
logging::SystemErrorCode mmap_error = logging::GetLastSystemErrorCode();
On 2017/02/24 at 00:46:18, reveman wrote:
> nit: please add a TODO comment with a bug reference here for removing this
temporary diagnostics when we've been able to determine what's causing these
failures

Done.

https://codereview.chromium.org/2710183005/diff/20001/ui/ozone/platform/drm/c...
ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc:98: } else {
On 2017/02/24 at 00:46:18, reveman wrote:
> nit: remove else as base::TerminateBecauseOutOfMemory will never return

Done.

[Robert Sesek, 2017-02-24 17:01:33]

LGTM

[Daniele Castagna, 2017-02-24 18:25:13]

dcastagna@chromium.org changed reviewers:
+ rjkroege@chromium.org

[Daniele Castagna, 2017-02-24 18:25:14]

+rjkroege for ownership since dnicoara is OOO.

[dshwang, 2017-02-24 19:31:25]

lgtm, I learnt how to get logs. nice!

[dnicoara, 2017-02-27 15:11:29]

lgtm

[Daniele Castagna, 2017-02-27 15:20:07]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2017-02-27 15:20:07]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2710183005/#ps40001
(title: "Address reveman's nits.")

[commit-bot: I haz the power, 2017-02-27 15:20:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 16:04:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488208807380040,
"parent_rev": "cf94fc4e6645c871037ff33ab3df3ef348902d86", "commit_rev":
"7288c33cfa94a7d45a98eb3cdb4dd5ef11da9d3b"}

[commit-bot: I haz the power, 2017-02-27 16:05:22]

Description was changed from

==========
ozone: drm: Add more details when dmabuf mmap fails.

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds more information when dmabuf mmap fails in the crash report
that is uploaded.
It adds the values of the parameters passed to mmap, the validity of the fd
passed to mmap, the last errno set, and the logical size of the buffer.

Additionally, while we used to always report mmap failing as out of memory,
after this CL we'll differentiate based on the last system error set.

BUG=629521
==========

to

==========
ozone: drm: Add more details when dmabuf mmap fails.

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds more information when dmabuf mmap fails in the crash report
that is uploaded.
It adds the values of the parameters passed to mmap, the validity of the fd
passed to mmap, the last errno set, and the logical size of the buffer.

Additionally, while we used to always report mmap failing as out of memory,
after this CL we'll differentiate based on the last system error set.

BUG=629521

Review-Url: https://codereview.chromium.org/2710183005
Cr-Commit-Position: refs/heads/master@{#453226}
Committed:
https://chromium.googlesource.com/chromium/src/+/7288c33cfa94a7d45a98eb3cdb4d...
==========

[commit-bot: I haz the power, 2017-02-27 16:05:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7288c33cfa94a7d45a98eb3cdb4d...