ozone: drm: Add more debug details when dmabuf mmap fails.

ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.h"
 
 #include <fcntl.h>
 #include <linux/version.h>
 #include <stddef.h>
 #include <sys/mman.h>
 #include <xf86drm.h>
 
+#include "base/debug/crash_logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/process/memory.h"
+#include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event.h"
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 6, 0)
 #include <linux/types.h>
 
 struct local_dma_buf_sync {
   __u64 flags;
 };
 
 #define LOCAL_DMA_BUF_SYNC_READ (1 << 0)
@@ skipping 48 matching lines @@
   // TODO(dcastagna): support multiple fds.
   DCHECK_EQ(1u, handle.fds.size());
   DCHECK_GE(handle.fds.front().fd, 0);
   dmabuf_fd_.reset(handle.fds.front().fd);
 
   DCHECK_GE(handle.planes.back().size, 0u);
   size_t map_size = handle.planes.back().offset + handle.planes.back().size;
   data_ = mmap(nullptr, map_size, (PROT_READ | PROT_WRITE), MAP_SHARED,
                dmabuf_fd_.get(), 0);
   if (data_ == MAP_FAILED) {
-    PLOG(ERROR) << "Failed mmap().";
-    base::TerminateBecauseOutOfMemory(map_size);
+    logging::SystemErrorCode mmap_error = logging::GetLastSystemErrorCode();

[reveman, 2017/02/24 00:46:18]

nit: please add a TODO comment with a bug reference here for removing this
temporary diagnostics when we've been able to determine what's causing these
failures

[Daniele Castagna, 2017/02/24 01:18:21]

Done.

+    bool fd_valid = fcntl(dmabuf_fd_.get(), F_GETFD) != -1 ||
+                    logging::GetLastSystemErrorCode() != EBADF;
+    std::string mmap_params = base::StringPrintf(
+        "(addr=nullptr, length=%zu, prot=(PROT_READ | PROT_WRITE), "
+        "flags=MAP_SHARED, fd=%d[valid=%d], offset=0)",
+        map_size, dmabuf_fd_.get(), fd_valid);
+    base::debug::ScopedCrashKey params_crash_key("mmap_params", mmap_params);
+    base::debug::ScopedCrashKey size_crash_key("buffer_size", size.ToString());
+    base::debug::ScopedCrashKey errno_crash_key(
+        "errno", logging::SystemErrorCodeToString(mmap_error));
+    if (mmap_error == ENOMEM) {
+      base::TerminateBecauseOutOfMemory(map_size);
+    } else {

[reveman, 2017/02/24 00:46:18]

nit: remove else as base::TerminateBecauseOutOfMemory will never return

[Daniele Castagna, 2017/02/24 01:18:21]

Done.

+      CHECK(false) << "Failed to mmap dmabuf.";
+    }
   }
 }
 
 ClientNativePixmapDmaBuf::~ClientNativePixmapDmaBuf() {
   TRACE_EVENT0("drm", "~ClientNativePixmapDmaBuf");
   size_t map_size =
       pixmap_handle_.planes.back().offset + pixmap_handle_.planes.back().size;
   int ret = munmap(data_, map_size);
   DCHECK(!ret);
 }
@@ skipping 17 matching lines @@
   uint8_t* address = reinterpret_cast<uint8_t*>(data_);
   return address + pixmap_handle_.planes[plane].offset;
 }
 
 int ClientNativePixmapDmaBuf::GetStride(size_t plane) const {
   DCHECK_LT(plane, pixmap_handle_.planes.size());
   return pixmap_handle_.planes[plane].stride;
 }
 
 }  // namespace ui