Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2710153002: PPC: Add OPCODE_LIST macro (Closed)

Created:
3 years, 10 months ago by Sampson
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move modification of assembler function declaration and definition to another commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2536 lines, -300 lines) Patch
M src/ppc/assembler-ppc.cc View 1 8 chunks +8 lines, -9 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ppc/constants-ppc.h View 4 chunks +2485 lines, -254 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 13 chunks +18 lines, -17 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 15 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Sampson
Please take a look.
3 years, 10 months ago (2017-02-22 22:27:39 UTC) #1
JaideepBajwa
lgtm with comments. https://codereview.chromium.org/2710153002/diff/1/src/ppc/assembler-ppc.h File src/ppc/assembler-ppc.h (right): https://codereview.chromium.org/2710153002/diff/1/src/ppc/assembler-ppc.h#newcode556 src/ppc/assembler-ppc.h:556: #define DECLARE_PPC_XX3_INSTRUCTIONS(name, instr_name, instr_value) \ .h ...
3 years, 10 months ago (2017-02-24 03:41:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710153002/20001
3 years, 10 months ago (2017-02-24 17:18:17 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-24 17:18:19 UTC) #7
john.yan
lgtm
3 years, 10 months ago (2017-02-24 18:07:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710153002/20001
3 years, 10 months ago (2017-02-24 18:08:06 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 18:34:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c605ea0322ff9c791d326eeeca3e45624f2...

Powered by Google App Engine
This is Rietveld 408576698