Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2710073002: Never show the default browser prompt over the first run promos (Closed)

Created:
3 years, 10 months ago by Patrick Monette
Modified:
3 years, 10 months ago
Reviewers:
tmartino
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Never show the default browser prompt over the first run promos Also expose first_run::IsOnWelcomePage() so it can be reused. BUG=693292 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2692203009 Cr-Commit-Position: refs/heads/master@{#451794} (cherry picked from commit 31b2815487e8c7edcc7ae481cc3494887110ace3) Review-Url: https://codereview.chromium.org/2710073002 Cr-Commit-Position: refs/branch-heads/2987@{#644} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f93abaa502aed3360e0222f7f27dc05243961379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M chrome/browser/first_run/first_run.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 3 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tmartino
lgtm
3 years, 10 months ago (2017-02-22 19:20:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710073002/1
3 years, 10 months ago (2017-02-22 19:41:43 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-22 19:41:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710073002/1
3 years, 10 months ago (2017-02-22 19:44:24 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 19:48:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f93abaa502aed3360e0222f7f27d...

Powered by Google App Engine
This is Rietveld 408576698