Never show the default browser prompt over the first run promos

Never show the default browser prompt over the first run promos

Also expose first_run::IsOnWelcomePage() so it can be reused.

BUG=693292
Review-Url: https://codereview.chromium.org/2692203009
Cr-Commit-Position: refs/heads/master@{#451794}
Committed: https://chromium.googlesource.com/chromium/src/+/31b2815487e8c7edcc7ae481cc3494887110ace3

[Patrick Monette, 2017-02-17 00:04:31]

Description was changed from

==========
Never show the default browser prompt over the first run promos

BUG=693110
==========

to

==========
Never show the default browser prompt over the first run promos

BUG=693110
==========

[Patrick Monette, 2017-02-17 00:09:36]

Description was changed from

==========
Never show the default browser prompt over the first run promos

BUG=693110
==========

to

==========
Never show the default browser prompt over the first run promos

Also expose first_run::IsOnWelcomePage() so it can be reused.

BUG=693110
==========

[Patrick Monette, 2017-02-17 00:10:04]

pmonette@chromium.org changed reviewers:
+ gab@chromium.org, pkasting@chromium.org

[Patrick Monette, 2017-02-17 00:10:05]

Hi,
This is a quick fix that is meant to be merged so I added a todo to clean up the
logic.

pkasting@ for default_browser_prompt.cc
gab@ for first_run.cc/h

[Peter Kasting, 2017-02-17 00:47:17]

LGTM

https://codereview.chromium.org/2692203009/diff/1/chrome/browser/ui/startup/d...
File chrome/browser/ui/startup/default_browser_prompt.cc (right):

https://codereview.chromium.org/2692203009/diff/1/chrome/browser/ui/startup/d...
chrome/browser/ui/startup/default_browser_prompt.cc:57: // TODO(pmonette): The
whole logic that determines when to show the default
Nit: Maybe want an associated bug

[Patrick Monette, 2017-02-17 01:04:58]

https://codereview.chromium.org/2692203009/diff/1/chrome/browser/ui/startup/d...
File chrome/browser/ui/startup/default_browser_prompt.cc (right):

https://codereview.chromium.org/2692203009/diff/1/chrome/browser/ui/startup/d...
chrome/browser/ui/startup/default_browser_prompt.cc:57: // TODO(pmonette): The
whole logic that determines when to show the default
On 2017/02/17 00:47:17, Peter Kasting wrote:
> Nit: Maybe want an associated bug

Good point. Done.

[Patrick Monette, 2017-02-17 01:05:25]

Description was changed from

==========
Never show the default browser prompt over the first run promos

Also expose first_run::IsOnWelcomePage() so it can be reused.

BUG=693110
==========

to

==========
Never show the default browser prompt over the first run promos

Also expose first_run::IsOnWelcomePage() so it can be reused.

BUG=693292
==========

[gab, 2017-02-17 20:57:39]

first_run lgtm

[Patrick Monette, 2017-02-18 00:29:35]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2017-02-18 00:29:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2692203009/#ps10001
(title: "Added bug link")

[commit-bot: I haz the power, 2017-02-18 00:31:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:36:41]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Patrick Monette, 2017-02-21 16:38:42]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:39:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:56:26]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1487695122498170,
"parent_rev": "1e1a3f896c2f0d334a6f2a81862013ebd798f832", "commit_rev":
"31b2815487e8c7edcc7ae481cc3494887110ace3"}

[commit-bot: I haz the power, 2017-02-21 17:57:07]

Description was changed from

==========
Never show the default browser prompt over the first run promos

Also expose first_run::IsOnWelcomePage() so it can be reused.

BUG=693292
==========

to

==========
Never show the default browser prompt over the first run promos

Also expose first_run::IsOnWelcomePage() so it can be reused.

BUG=693292

Review-Url: https://codereview.chromium.org/2692203009
Cr-Commit-Position: refs/heads/master@{#451794}
Committed:
https://chromium.googlesource.com/chromium/src/+/31b2815487e8c7edcc7ae481cc34...
==========

[commit-bot: I haz the power, 2017-02-21 17:57:08]

Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/31b2815487e8c7edcc7ae481cc34...