Issue 2710023009: media: Stop sending if-match headers for media fetch requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2710023009: media: Stop sending if-match headers for media fetch requests. (Closed)

Created:
3 years, 10 months ago by hubbe

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

media: Stop sending if-match headers for media fetch requests. Sending if-match headers disables caching, so stop doing that until we can think of a better solution. BUG=689989, 504194 Review-Url: https://codereview.chromium.org/2714583002 Cr-Commit-Position: refs/heads/master@{#452323} (cherry picked from commit 9974e4f50017f116c3696ce9cc38680e77ac14f1)

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -12 lines)			Patch
	M	media/blink/resource_multibuffer_data_provider.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
	M	media/blink/resource_multibuffer_data_provider_unittest.cc	View		2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hubbe

3 years, 9 months ago (2017-03-16 17:52:49 UTC) #1

Description was changed from

==========
media: Stop sending if-match headers for media fetch requests.

Sending if-match headers disables caching, so stop doing that
until we can think of a better solution.

BUG=689989, 504194

Review-Url: https://codereview.chromium.org/2714583002
Cr-Commit-Position: refs/heads/master@{#452323}
(cherry picked from commit 9974e4f50017f116c3696ce9cc38680e77ac14f1)
==========

to

==========
media: Stop sending if-match headers for media fetch requests.

Sending if-match headers disables caching, so stop doing that
until we can think of a better solution.

BUG=689989, 504194

Review-Url: https://codereview.chromium.org/2714583002
Cr-Commit-Position: refs/heads/master@{#452323}
(cherry picked from commit 9974e4f50017f116c3696ce9cc38680e77ac14f1)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages