Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: media/blink/resource_multibuffer_data_provider.cc

Issue 2710023009: media: Stop sending if-match headers for media fetch requests. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/resource_multibuffer_data_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/resource_multibuffer_data_provider.cc
diff --git a/media/blink/resource_multibuffer_data_provider.cc b/media/blink/resource_multibuffer_data_provider.cc
index 9ef0684479330e51c6a5fcec9fda27f445c09604..f1f80f07823f60f9f15875d87437c18f44b13d8c 100644
--- a/media/blink/resource_multibuffer_data_provider.cc
+++ b/media/blink/resource_multibuffer_data_provider.cc
@@ -85,10 +85,11 @@ void ResourceMultiBufferDataProvider::Start() {
WebString::fromUTF8(
net::HttpByteRange::RightUnbounded(byte_pos()).GetHeaderValue()));
- if (!url_data_->etag().empty()) {
- request.setHTTPHeaderField(WebString::fromUTF8("If-Match"),
- WebString::fromUTF8(url_data_->etag()));
- }
+ // We would like to send an if-match header with the request to
+ // tell the remote server that we really can't handle files other
+ // than the one we already started playing. Unfortunately, doing
+ // so will disable the http cache, and possibly other proxies
+ // along the way. See crbug/504194 and crbug/689989 for more information.
url_data_->frame()->setReferrerForRequest(request, blink::WebURL());
« no previous file with comments | « no previous file | media/blink/resource_multibuffer_data_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698