Delete RenderWidgetHostViewChildFrame on Destroy().

Delete RenderWidgetHostViewChildFrame on Destroy().

This CL changes RenderWidgetHostViewChildFrame to be synchronously deleted when Destroy() is called. This makes sure that the destructor is called on tests, and prevents complicated lifetime management for objects that depend on RenderWidgetHostViewChildFrame.

BUG=624065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2710023008
Cr-Commit-Position: refs/heads/master@{#453032}
Committed: https://chromium.googlesource.com/chromium/src/+/f40832ec30f1e19f28ca4dfab9e24d608fcefa28

[lfg, 2017-02-24 18:17:22]

Description was changed from

==========
WIP
==========

to

==========
WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[lfg, 2017-02-24 18:19:39]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 18:20:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 18:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 18:48:50]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lfg, 2017-02-24 20:10:46]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 20:11:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lfg, 2017-02-24 21:18:20]

Description was changed from

==========
WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Delete RenderWidgetHostViewChildFrame on Destroy().

This CL changes RenderWidgetHostViewChildFrame to be synchronously deleted when
Destroy() is called. This makes sure that the destructor is called on tests, and
prevents complicated lifetime management for objects that depend on
RenderWidgetHostViewChildFrame.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[lfg, 2017-02-24 21:18:51]

Description was changed from

==========
Delete RenderWidgetHostViewChildFrame on Destroy().

This CL changes RenderWidgetHostViewChildFrame to be synchronously deleted when
Destroy() is called. This makes sure that the destructor is called on tests, and
prevents complicated lifetime management for objects that depend on
RenderWidgetHostViewChildFrame.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Delete RenderWidgetHostViewChildFrame on Destroy().

This CL changes RenderWidgetHostViewChildFrame to be synchronously deleted when
Destroy() is called. This makes sure that the destructor is called on tests, and
prevents complicated lifetime management for objects that depend on
RenderWidgetHostViewChildFrame.

BUG=624065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[lfg, 2017-02-24 21:24:34]

lfg@chromium.org changed reviewers:
+ kenrb@chromium.org

[lfg, 2017-02-24 21:24:46]

Ken, can you take a look?

[kenrb, 2017-02-24 21:29:09]

lgtm, as long as tests are green and there are no observable issues with
GuestView or --site-per-process. This could simplify a lot of things in future,
as we have occasionally had to work around the destroyed-but-not-deleted state
of these things.

[lfg, 2017-02-24 21:43:13]

lfg@chromium.org changed reviewers:
+ alexmos@chromium.org

[lfg, 2017-02-24 21:43:13]

Alex, can you take a look?

[commit-bot: I haz the power, 2017-02-24 21:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:51:15]

Dry run: This issue passed the CQ dry run.

[alexmos, 2017-02-25 00:02:41]

LGTM.  Tests are green, let's give this a try.

[lfg, 2017-02-25 00:53:06]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:58:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487983986953020,
"parent_rev": "d07409811fbcafff033382f0a963b2ba30283e9d", "commit_rev":
"f40832ec30f1e19f28ca4dfab9e24d608fcefa28"}

[commit-bot: I haz the power, 2017-02-25 00:59:51]

Description was changed from

==========
Delete RenderWidgetHostViewChildFrame on Destroy().

This CL changes RenderWidgetHostViewChildFrame to be synchronously deleted when
Destroy() is called. This makes sure that the destructor is called on tests, and
prevents complicated lifetime management for objects that depend on
RenderWidgetHostViewChildFrame.

BUG=624065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Delete RenderWidgetHostViewChildFrame on Destroy().

This CL changes RenderWidgetHostViewChildFrame to be synchronously deleted when
Destroy() is called. This makes sure that the destructor is called on tests, and
prevents complicated lifetime management for objects that depend on
RenderWidgetHostViewChildFrame.

BUG=624065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2710023008
Cr-Commit-Position: refs/heads/master@{#453032}
Committed:
https://chromium.googlesource.com/chromium/src/+/f40832ec30f1e19f28ca4dfab9e2...
==========

[commit-bot: I haz the power, 2017-02-25 00:59:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f40832ec30f1e19f28ca4dfab9e2...