Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 2710023008: Delete RenderWidgetHostViewChildFrame on Destroy(). (Closed)
Patch Set: fix guest Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_widget_host_view_guest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc
index 93ea21f4b63ecb978654fe2d436e40d19dd67445..2197f73ad506ddacd642f091dc8e44e4ade2ba92 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest.cc
@@ -239,10 +239,11 @@ void RenderWidgetHostViewGuest::RenderProcessGone(
}
void RenderWidgetHostViewGuest::Destroy() {
- RenderWidgetHostViewChildFrame::Destroy();
-
if (platform_view_) // The platform view might have been destroyed already.
platform_view_->Destroy();
+
+ // RenderWidgetHostViewChildFrame::Destroy destroys this object.
+ RenderWidgetHostViewChildFrame::Destroy();
}
gfx::Size RenderWidgetHostViewGuest::GetPhysicalBackingSize() const {
« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698