Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2710003003: omnibox: use dark border stroke in Increase Contrast mode (Closed)

Created:
3 years, 10 months ago by Elly Fong-Jones
Modified:
3 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

omnibox: use dark border stroke in Increase Contrast mode BUG=687227 Review-Url: https://codereview.chromium.org/2710003003 Cr-Commit-Position: refs/heads/master@{#452546} Committed: https://chromium.googlesource.com/chromium/src/+/2c766c7081a39d69bdde6f008f1c5e0dc6d4388c

Patch Set 1 #

Total comments: 6

Patch Set 2 : relocate some constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Elly Fong-Jones
mark: ptal? :)
3 years, 10 months ago (2017-02-22 20:28:00 UTC) #3
Mark Mentovai
LGTM https://codereview.chromium.org/2710003003/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm (right): https://codereview.chromium.org/2710003003/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm#newcode367 chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:367: const CGFloat kNormalStrokeGray = 168 / 255.; Scope ...
3 years, 10 months ago (2017-02-23 01:57:28 UTC) #4
Elly Fong-Jones
https://codereview.chromium.org/2710003003/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm (right): https://codereview.chromium.org/2710003003/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm#newcode367 chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:367: const CGFloat kNormalStrokeGray = 168 / 255.; On 2017/02/23 ...
3 years, 10 months ago (2017-02-23 17:32:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710003003/20001
3 years, 10 months ago (2017-02-23 17:32:49 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:54:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c766c7081a39d69bdde6f008f1c...

Powered by Google App Engine
This is Rietveld 408576698