omnibox: use dark border stroke in Increase Contrast mode

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
@@ skipping 343 matching lines @@
 
   // Fill the background.
   [[self backgroundColor] set];
   if (isPopupMode_) {
     NSRectFillUsingOperation(NSInsetRect(frame, 1, 1), NSCompositeSourceOver);
   } else {
     [path fill];
   }
 
   // Draw the border.
+  const ui::ThemeProvider* provider = [[controlView window] themeProvider];
+  bool increaseContrast = provider && provider->ShouldIncreaseContrast();
   if (!inDarkMode) {
     const CGFloat kNormalStrokeGray = 168 / 255.;

[Mark Mentovai, 2017/02/23 01:57:28]

Scope tightly to where it’s used, inside the else branch within the if.

[Elly Fong-Jones, 2017/02/23 17:32:16]

Done.

-    [[NSColor colorWithCalibratedWhite:kNormalStrokeGray alpha:1] set];
+    if (increaseContrast)
+      [[NSColor blackColor] set];
+    else
+      [[NSColor colorWithCalibratedWhite:kNormalStrokeGray alpha:1] set];
   } else {
     const CGFloat k30PercentAlpha = 0.3;

[Mark Mentovai, 2017/02/23 01:57:28]

Me too.

[Elly Fong-Jones, 2017/02/23 17:32:16]

Done.

-    [[NSColor colorWithCalibratedWhite:0 alpha:k30PercentAlpha] set];
+    if (increaseContrast)
+      [[NSColor whiteColor] set];
+    else
+      [[NSColor colorWithCalibratedWhite:0 alpha:k30PercentAlpha] set];
   }

[Mark Mentovai, 2017/02/23 01:57:28]

Not required, but consider factoring the -set out to be common.

  NSColor* color;
  if (!inDarkMode) {
    if (increaseContrast) {
      color = [NSColor blackColor];
  // … blah blah blah
    }
  }
  [color set];

[Elly Fong-Jones, 2017/02/23 17:32:16]

I thought about doing this but I don't think it's significantly more or less
clear, so I just left it.

   [path stroke];
 
   // Draw the interior contents. We do this after drawing the border as some
   // of the interior controls draw over it.
   [self drawInteriorWithFrame:frame inView:controlView];
 
   // Draw the focus ring.
   if (showingFirstResponder) {
     CGFloat alphaComponent = 0.5 / singlePixelLineWidth_;
     if (inDarkMode) {
@@ skipping 347 matching lines @@
 
 @end
 
 @implementation AutocompleteTextFieldCell (TestingAPI)
 
 - (const std::vector<LocationBarDecoration*>&)mouseTrackingDecorations {
   return mouseTrackingDecorations_;
 }
 
 @end