Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2709973005: Get rid of useless function VisibleSelection::updateIfNeeded() (Closed)
Patch Set: 2017-02-24T19:18:36 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
index b7b041535dd8116f787aab960ee6dc15f520fb37..0b2fe466b9269423061422419cbc6a2e733475ee 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
@@ -479,7 +479,7 @@ TEST_F(VisibleSelectionTest, updateIfNeededWithShadowHost) {
document().updateStyleAndLayout();
// Simulates to restore selection from undo stack.
- selection.updateIfNeeded();
+ selection = createVisibleSelection(selection.asSelection());
EXPECT_EQ(Position(sample->firstChild(), 0), selection.start());
}

Powered by Google App Engine
This is Rietveld 408576698