Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2709913002: Fix OnceCallback support of base::ResetAndReturn (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix OnceCallback support of base::ResetAndReturn ResetAndReturn's OnceCallback was broken, since it tried to copy the move only OnceCallback. This CL fixes that and adds test for it. Review-Url: https://codereview.chromium.org/2709913002 Cr-Commit-Position: refs/heads/master@{#451949} Committed: https://chromium.googlesource.com/chromium/src/+/6eb028403e170e62a0c63670a4bcaac80bc4a8a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M base/callback_helpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/callback_helpers_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-22 05:53:49 UTC) #4
dcheng
lgtm
3 years, 10 months ago (2017-02-22 07:17:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709913002/1
3 years, 10 months ago (2017-02-22 07:30:45 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 09:14:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6eb028403e170e62a0c63670a4bc...

Powered by Google App Engine
This is Rietveld 408576698