Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2711453003:
Refactor media::CallbackHolder (Closed)
DescriptionRefactor media::CallbackHolder
This CL unifies CallbackHolder::RunOrHold overloads and replaces
TrampolineForward with std::forward, so that callback_holder.h no longer
depends on bind_to_current_loop.h
Review-Url: https://codereview.chromium.org/2711453003
Cr-Commit-Position: refs/heads/master@{#452399}
Committed: https://chromium.googlesource.com/chromium/src/+/ab9738f225331a756ec93dadef546130b7aa5fe2
Patch Set 1 #Patch Set 2 : style fix #
Depends on Patchset: Messages
Total messages: 20 (16 generated)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Refactor //media/base/callback_holder.h ========== to ========== Refactor media::CallbackHolder ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Refactor media::CallbackHolder ========== to ========== Refactor media::CallbackHolder This CL unifies CallbackHolder::RunOrHold overloads and replaces TrampolineForward with std::forward, so that callback_holder.h no longer depends on bind_to_current_loop.h ==========
tzik@chromium.org changed reviewers: + xhwang@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Cool, thanks for doing this! LGTM
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487826245663280,
"parent_rev": "ae35cba1ac1686f9809f35533988cb09a282306a", "commit_rev":
"ab9738f225331a756ec93dadef546130b7aa5fe2"}
Message was sent while issue was closed.
Description was changed from ========== Refactor media::CallbackHolder This CL unifies CallbackHolder::RunOrHold overloads and replaces TrampolineForward with std::forward, so that callback_holder.h no longer depends on bind_to_current_loop.h ========== to ========== Refactor media::CallbackHolder This CL unifies CallbackHolder::RunOrHold overloads and replaces TrampolineForward with std::forward, so that callback_holder.h no longer depends on bind_to_current_loop.h Review-Url: https://codereview.chromium.org/2711453003 Cr-Commit-Position: refs/heads/master@{#452399} Committed: https://chromium.googlesource.com/chromium/src/+/ab9738f225331a756ec93dadef54... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ab9738f225331a756ec93dadef54... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
