Chromium Code Reviews Chromium Code Reviews
Issue
2709863002:
Revert of Avoid pathological layout on nested percent height tables (patchset #5 id:80001 of https:… (Closed)
DescriptionRevert of Avoid pathological layout on nested percent height tables (patchset #5 id:80001 of https://codereview.chromium.org/2670603002/ )
Reason for revert:
Broke Google Hangouts.
BUG=693722
Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
>
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(), layoutRows())
> during the layout of the section - and this cascades down the tree with the lowest
> children getting hundreds of repeated layouts.
>
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
>
> To avoid this don't bother computing the height of the section based on row sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value will do.
>
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause extra
> paints.
>
>
> BUG=687061
>
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed: https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362d6221cb72302
TBR=mstensho@opera.com,robhogan@gmail.com
BUG=687061
NOTRY=true
Review-Url: https://codereview.chromium.org/2700183003
Cr-Commit-Position: refs/heads/master@{#451451}
(cherry picked from commit 91d8afa35df85de452b08ca5c7032fb1456a541a)
Review-Url: https://codereview.chromium.org/2709863002 .
Cr-Commit-Position: refs/branch-heads/2987@{#618}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/f3b0f9b1e57c31ffd21e4bd6d131a0ef2643423b
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
