Revert of Avoid pathological layout on nested percent height tables

Revert of Avoid pathological layout on nested percent height tables (patchset #5 id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722
Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
> 
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(), layoutRows()) 
> during the layout of the section - and this cascades down the tree with the lowest
> children getting hundreds of repeated layouts.
> 
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
> 
> To avoid this don't bother computing the height of the section based on row sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value will do.
> 
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause extra
> paints.
> 
> 
> BUG=687061
> 
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed: https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362d6221cb72302

TBR=mstensho@opera.com,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687061
NOTRY=true

Review-Url: https://codereview.chromium.org/2700183003
Cr-Commit-Position: refs/heads/master@{#451451}
Committed: https://chromium.googlesource.com/chromium/src/+/91d8afa35df85de452b08ca5c7032fb1456a541a

[eae, 2017-02-17 23:01:05]

The CQ bit was checked by eae@chromium.org

[eae, 2017-02-17 23:01:05]

Created Revert of Avoid pathological layout on nested percent height tables

[eae, 2017-02-17 23:01:25]

Description was changed from

==========
Revert of Avoid pathological layout on nested percent height tables (patchset #5
id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722

Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
> 
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(),
layoutRows()) 
> during the layout of the section - and this cascades down the tree with the
lowest
> children getting hundreds of repeated layouts.
> 
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
> 
> To avoid this don't bother computing the height of the section based on row
sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value
will do.
> 
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause
extra
> paints.
> 
> 
> BUG=687061
> 
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362...

TBR=mstensho@opera.com,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687061
==========

to

==========
Revert of Avoid pathological layout on nested percent height tables (patchset #5
id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722

Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
> 
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(),
layoutRows()) 
> during the layout of the section - and this cascades down the tree with the
lowest
> children getting hundreds of repeated layouts.
> 
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
> 
> To avoid this don't bother computing the height of the section based on row
sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value
will do.
> 
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause
extra
> paints.
> 
> 
> BUG=687061
> 
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362...

TBR=mstensho@opera.com,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687061
==========

[commit-bot: I haz the power, 2017-02-17 23:04:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:09:06]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[eae, 2017-02-18 01:42:38]

Description was changed from

==========
Revert of Avoid pathological layout on nested percent height tables (patchset #5
id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722

Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
> 
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(),
layoutRows()) 
> during the layout of the section - and this cascades down the tree with the
lowest
> children getting hundreds of repeated layouts.
> 
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
> 
> To avoid this don't bother computing the height of the section based on row
sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value
will do.
> 
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause
extra
> paints.
> 
> 
> BUG=687061
> 
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362...

TBR=mstensho@opera.com,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687061
==========

to

==========
Revert of Avoid pathological layout on nested percent height tables (patchset #5
id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722

Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
> 
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(),
layoutRows()) 
> during the layout of the section - and this cascades down the tree with the
lowest
> children getting hundreds of repeated layouts.
> 
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
> 
> To avoid this don't bother computing the height of the section based on row
sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value
will do.
> 
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause
extra
> paints.
> 
> 
> BUG=687061
> 
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362...

TBR=mstensho@opera.com,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687061
NOTRY=true
==========

[eae, 2017-02-18 01:42:44]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:43:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:45:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:45:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[rhogan, 2017-02-18 09:59:32]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2017-02-18 09:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 10:04:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487411972532840, "parent_rev":
"2b4c744a184c96c5ea0778e91cb11a0acc7215df", "commit_rev":
"91d8afa35df85de452b08ca5c7032fb1456a541a"}

[commit-bot: I haz the power, 2017-02-18 10:05:19]

Description was changed from

==========
Revert of Avoid pathological layout on nested percent height tables (patchset #5
id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722

Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
> 
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(),
layoutRows()) 
> during the layout of the section - and this cascades down the tree with the
lowest
> children getting hundreds of repeated layouts.
> 
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
> 
> To avoid this don't bother computing the height of the section based on row
sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value
will do.
> 
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause
extra
> paints.
> 
> 
> BUG=687061
> 
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362...

TBR=mstensho@opera.com,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687061
NOTRY=true
==========

to

==========
Revert of Avoid pathological layout on nested percent height tables (patchset #5
id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722

Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
> 
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(),
layoutRows()) 
> during the layout of the section - and this cascades down the tree with the
lowest
> children getting hundreds of repeated layouts.
> 
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
> 
> To avoid this don't bother computing the height of the section based on row
sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value
will do.
> 
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause
extra
> paints.
> 
> 
> BUG=687061
> 
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362...

TBR=mstensho@opera.com,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=687061
NOTRY=true

Review-Url: https://codereview.chromium.org/2700183003
Cr-Commit-Position: refs/heads/master@{#451451}
Committed:
https://chromium.googlesource.com/chromium/src/+/91d8afa35df85de452b08ca5c703...
==========

[commit-bot: I haz the power, 2017-02-18 10:05:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91d8afa35df85de452b08ca5c703...