third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)

Patch Set: Addressing dcheng@'s comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index bd57f5d03625a57af772bcd7e22139d2596b4fe1..4628e466fea7547f40042ecfca92a483232aa406 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -1069,9 +1069,11 @@ void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) {

webframe->autofillClient()->didAssociateFormControlsDynamically();

}

-void ChromeClientImpl::showVirtualKeyboardOnElementFocus() {

- if (m_webView->client())

- m_webView->client()->showVirtualKeyboardOnElementFocus();

+void ChromeClientImpl::showVirtualKeyboardOnElementFocus(LocalFrame& frame) {

+ WebLocalFrameImpl::fromFrame(frame.localFrameRoot())

+ ->frameWidget()

+ ->client()

+ ->showVirtualKeyboardOnElementFocus();

}

void ChromeClientImpl::showUnhandledTapUIIfNeeded(