Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)
Patch Set: Addressing dcheng@'s comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp b/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
index ef9faf104dc281cfc96fd38462baf22ea3fc98bc..5a1daf3a5746efb326051b989e3ade41f1ef339f 100644
--- a/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
@@ -22,7 +22,7 @@ using blink::URLTestHelpers::registerMockedURLLoadFromBase;
namespace blink {
class ImeRequestTrackingWebViewClient
- : public FrameTestHelpers::TestWebViewClient {
+ : public FrameTestHelpers::TestWebWidgetClient {
public:
ImeRequestTrackingWebViewClient() : m_virtualKeyboardRequestCount(0) {}
@@ -95,7 +95,7 @@ void ImeOnFocusTest::runImeOnFocusTest(std::string fileName,
registerMockedURLLoadFromBase(WebString::fromUTF8(m_baseURL),
testing::webTestDataPath(),
WebString::fromUTF8(fileName));
- WebViewImpl* webView = m_webViewHelper.initialize(true, 0, &client);
+ WebViewImpl* webView = m_webViewHelper.initialize(true, 0, nullptr, &client);
webView->resize(WebSize(800, 1200));
loadFrame(webView->mainFrame(), m_baseURL + fileName);
m_document =
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698