Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)
Patch Set: Addressing dcheng@'s comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 if (WebViewClient* client = m_webView->client()) 1062 if (WebViewClient* client = m_webView->client())
1063 client->draggableRegionsChanged(); 1063 client->draggableRegionsChanged();
1064 } 1064 }
1065 1065
1066 void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) { 1066 void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) {
1067 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame); 1067 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);
1068 if (webframe->autofillClient()) 1068 if (webframe->autofillClient())
1069 webframe->autofillClient()->didAssociateFormControlsDynamically(); 1069 webframe->autofillClient()->didAssociateFormControlsDynamically();
1070 } 1070 }
1071 1071
1072 void ChromeClientImpl::showVirtualKeyboardOnElementFocus() { 1072 void ChromeClientImpl::showVirtualKeyboardOnElementFocus(LocalFrame& frame) {
1073 if (m_webView->client()) 1073 WebLocalFrameImpl::fromFrame(frame.localFrameRoot())
1074 m_webView->client()->showVirtualKeyboardOnElementFocus(); 1074 ->frameWidget()
1075 ->client()
1076 ->showVirtualKeyboardOnElementFocus();
1075 } 1077 }
1076 1078
1077 void ChromeClientImpl::showUnhandledTapUIIfNeeded( 1079 void ChromeClientImpl::showUnhandledTapUIIfNeeded(
1078 IntPoint tappedPositionInViewport, 1080 IntPoint tappedPositionInViewport,
1079 Node* tappedNode, 1081 Node* tappedNode,
1080 bool pageChanged) { 1082 bool pageChanged) {
1081 if (m_webView->client()) 1083 if (m_webView->client())
1082 m_webView->client()->showUnhandledTapUIIfNeeded( 1084 m_webView->client()->showUnhandledTapUIIfNeeded(
1083 WebPoint(tappedPositionInViewport), WebNode(tappedNode), pageChanged); 1085 WebPoint(tappedPositionInViewport), WebNode(tappedNode), pageChanged);
1084 } 1086 }
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1221 PresentationController::provideTo(frame, client->presentationClient()); 1223 PresentationController::provideTo(frame, client->presentationClient());
1222 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1224 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1223 provideAudioOutputDeviceClientTo(frame, 1225 provideAudioOutputDeviceClientTo(frame,
1224 new AudioOutputDeviceClientImpl(frame)); 1226 new AudioOutputDeviceClientImpl(frame));
1225 } 1227 }
1226 if (RuntimeEnabledFeatures::installedAppEnabled()) 1228 if (RuntimeEnabledFeatures::installedAppEnabled())
1227 InstalledAppController::provideTo(frame, client->relatedAppsFetcher()); 1229 InstalledAppController::provideTo(frame, client->relatedAppsFetcher());
1228 } 1230 }
1229 1231
1230 } // namespace blink 1232 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698