Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 2709623002: selection: Do not run invalid sub-tests with unselectable endpoints. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

selection: Do not run invalid sub-tests with unselectable endpoints. collapseToStartEnd.html and isCollapsed.html assumed addRange() with nodes in different roots succeeded. It's not consistent with the latest draft. This CL removes 90 invalid tests, and removes 1 duplicated test for null endpoints. BUG=683066 Review-Url: https://codereview.chromium.org/2709623002 Cr-Commit-Position: refs/heads/master@{#451686} Committed: https://chromium.googlesource.com/chromium/src/+/5ace9e8b0287e6ab2b2beabf01e604fc327ad14b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -229 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd.html View 2 chunks +9 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt View 1 chunk +0 lines, -140 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed-expected.txt View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
yoichio@, yosin@, would you review this please? This is similar to https://codereview.chromium.org/2700673005 .
3 years, 10 months ago (2017-02-21 01:39:48 UTC) #5
yoichio
lgtm
3 years, 10 months ago (2017-02-21 02:09:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709623002/1
3 years, 10 months ago (2017-02-21 02:15:34 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 02:20:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ace9e8b0287e6ab2b2beabf01e6...

Powered by Google App Engine
This is Rietveld 408576698