third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html - Issue 2709623002: selection: Do not run invalid sub-tests with unselectable endpoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html

Issue 2709623002: selection: Do not run invalid sub-tests with unselectable endpoints. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt ('k') | third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html

diff --git a/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html b/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html

index 113a16db88d3a531de46b9a9c24267ea5a861872..819a3e297a3cf22f55e407d39f4d23d27fb3547a 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html

+++ b/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html

@@ -13,9 +13,11 @@ test(function() {

}, "Empty selection");

for (var i = 0; i < testRanges.length; i++) {

+ var endpoints = eval(testRanges[i]);

+ if (!isSelectableNode(endpoints[0]) || !isSelectableNode(endpoints[2]))

+ continue;

test(function() {

selection.removeAllRanges();

- var endpoints = eval(testRanges[i]);

var range = ownerDocument(endpoints[0]).createRange();

range.setStart(endpoints[0], endpoints[1]);

range.setEnd(endpoints[2], endpoints[3]);