Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html

Issue 2709623002: selection: Do not run invalid sub-tests with unselectable endpoints. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html b/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html
index 113a16db88d3a531de46b9a9c24267ea5a861872..819a3e297a3cf22f55e407d39f4d23d27fb3547a 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed.html
@@ -13,9 +13,11 @@ test(function() {
}, "Empty selection");
for (var i = 0; i < testRanges.length; i++) {
+ var endpoints = eval(testRanges[i]);
+ if (!isSelectableNode(endpoints[0]) || !isSelectableNode(endpoints[2]))
+ continue;
test(function() {
selection.removeAllRanges();
- var endpoints = eval(testRanges[i]);
var range = ownerDocument(endpoints[0]).createRange();
range.setStart(endpoints[0], endpoints[1]);
range.setEnd(endpoints[2], endpoints[3]);

Powered by Google App Engine
This is Rietveld 408576698