MD Settings: Internet page cleanup + simple tests

MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG=673944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}
Committed: https://chromium.googlesource.com/chromium/src/+/3f0dbfbfadfa62bd03b0dac618105ebe77d09090

[stevenjb, 2017-02-23 22:15:30]

Description was changed from

==========
MD Settings: Internet page cleanup

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

BUG=673944
==========

to

==========
MD Settings: Internet page cleanup

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

BUG=673944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-24 01:29:45]

Description was changed from

==========
MD Settings: Internet page cleanup

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

BUG=673944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by
no means exhaustive.

BUG=673944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-24 01:32:20]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-02-27 01:48:53]

lgtm with nits

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/cr_settings_browsertest.js (right):

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/cr_settings_browsertest.js:865: * Test fixture
for device-page.
internet

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/fake_networking_private.js (right):

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/fake_networking_private.js:1: // Copyright 2015
The Chromium Authors. All rights reserved.
2017

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/fake_networking_private.js:29: Ethernet: { Type:
'Ethernet', State: 'Enabled' },
nit: no space after { or before } is usually what I see

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/internet_page_tests.js (right):

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/internet_page_tests.js:12: 
nit: remove blank line

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/internet_page_tests.js:96: // Ensure that the
initial state is disabled and the toggle is
nit: add some spacing above comments

[stevenjb, 2017-02-27 17:38:33]

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/cr_settings_browsertest.js (right):

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/cr_settings_browsertest.js:865: * Test fixture
for device-page.
On 2017/02/27 01:48:53, michaelpg wrote:
> internet

Done.

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/fake_networking_private.js (right):

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/fake_networking_private.js:1: // Copyright 2015
The Chromium Authors. All rights reserved.
On 2017/02/27 01:48:53, michaelpg wrote:
> 2017

Done.

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/fake_networking_private.js:29: Ethernet: { Type:
'Ethernet', State: 'Enabled' },
On 2017/02/27 01:48:53, michaelpg wrote:
> nit: no space after { or before } is usually what I see

Done. (Ran clang format)

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/internet_page_tests.js (right):

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/internet_page_tests.js:12: 
On 2017/02/27 01:48:53, michaelpg wrote:
> nit: remove blank line

Done.

https://codereview.chromium.org/2709573006/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/internet_page_tests.js:96: // Ensure that the
initial state is disabled and the toggle is
On 2017/02/27 01:48:53, michaelpg wrote:
> nit: add some spacing above comments

Done.

[stevenjb, 2017-02-27 17:38:39]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-02-27 17:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2709573006/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2017-02-27 17:39:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:59:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488217119894520,
"parent_rev": "9c896117345da9d357b33abb157f9882597094b1", "commit_rev":
"3f0dbfbfadfa62bd03b0dac618105ebe77d09090"}

[commit-bot: I haz the power, 2017-02-27 19:00:36]

Description was changed from

==========
MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by
no means exhaustive.

BUG=673944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet page cleanup + simple tests

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by
no means exhaustive.

BUG=673944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f0dbfbfadfa62bd03b0dac61810...
==========

[commit-bot: I haz the power, 2017-02-27 19:00:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3f0dbfbfadfa62bd03b0dac61810...