Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/resources/settings/internet_page/network_summary.js

Issue 2709573006: MD Settings: Internet page cleanup + simple tests (Closed)
Patch Set: nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_summary.js
diff --git a/chrome/browser/resources/settings/internet_page/network_summary.js b/chrome/browser/resources/settings/internet_page/network_summary.js
index c27bb321018977156d50e9e4bbf20553476165b6..0b65a68fd959a582e8402a867ef60d18fe228612 100644
--- a/chrome/browser/resources/settings/internet_page/network_summary.js
+++ b/chrome/browser/resources/settings/internet_page/network_summary.js
@@ -61,11 +61,12 @@ Polymer({
* The device state for each network device type.
* @private {DeviceStateObject}
*/
- deviceStates_: {
+ deviceStates: {
type: Object,
value: function() {
return {};
},
+ notify: true,
},
/**
@@ -178,20 +179,6 @@ Polymer({
},
/**
- * Event triggered when the enabled state of a network-summary-item is
- * toggled.
- * @param {!{detail: {enabled: boolean,
- * type: chrome.networkingPrivate.NetworkType}}} event
- * @private
- */
- onDeviceEnabledToggled_: function(event) {
- if (event.detail.enabled)
- this.networkingPrivate.enableNetworkType(event.detail.type);
- else
- this.networkingPrivate.disableNetworkType(event.detail.type);
- },
-
- /**
* networkingPrivate.onNetworkListChanged event callback.
* @private
*/
@@ -346,7 +333,7 @@ Polymer({
newDeviceStates[state.Type] = state;
}
} else {
- newDeviceStates = this.deviceStates_;
+ newDeviceStates = this.deviceStates;
}
// Clear any current networks.
@@ -408,7 +395,7 @@ Polymer({
this.activeNetworkIds_.add(state.GUID);
}
- this.deviceStates_ = newDeviceStates;
+ this.deviceStates = newDeviceStates;
this.networkStateLists_ = newNetworkStateLists;
// Set activeNetworkStates last to rebuild the dom-repeat.
this.activeNetworkStates_ = newActiveNetworkStates;

Powered by Google App Engine
This is Rietveld 408576698