Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2709533002: Revert of [interpreter] Create custom call opcodes for specific argument counts (Closed)

Created:
3 years, 10 months ago by danno
Modified:
3 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, Leszek Swirski
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Create custom call opcodes for specific argument counts (patchset #13 id:240001 of https://codereview.chromium.org/2684993002/ ) Reason for revert: Due to arm64 failures Original issue's description: > [interpreter] Create custom call opcodes for specific argument counts > > Specifically, add bytecodes for Call0, Call1, Call2, CallProperty0, CallProperty1, > and CallProperty2. Also share the bytecode handler code between between > equivalent CallX and CallPropertyX handlers. > > Review-Url: https://codereview.chromium.org/2684993002 > Cr-Commit-Position: refs/heads/master@{#43290} > Committed: https://chromium.googlesource.com/v8/v8/+/00d6f1f80a00c4ac398af588dbd6815395791015 TBR=rmcilroy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2709533002 Cr-Commit-Position: refs/heads/master@{#43308} Committed: https://chromium.googlesource.com/v8/v8/+/1b3c4afcadf1a794e9f54800b1f0ce36ea5d7461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -410 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +4 lines, -17 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 4 chunks +27 lines, -121 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M src/interpreter/bytecode-pipeline.h View 4 chunks +1 line, -40 lines 0 comments Download
M src/interpreter/bytecodes.h View 3 chunks +1 line, -20 lines 0 comments Download
M src/interpreter/interpreter.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/interpreter/interpreter.cc View 6 chunks +11 lines, -91 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallGlobal.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeclareGlobals.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Eval.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 14 chunks +26 lines, -26 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 7 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlot.golden View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyCall.golden View 8 chunks +20 lines, -14 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RegExpLiterals.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
danno
Created Revert of [interpreter] Create custom call opcodes for specific argument counts
3 years, 10 months ago (2017-02-20 09:24:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709533002/1
3 years, 10 months ago (2017-02-20 09:24:13 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 09:51:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1b3c4afcadf1a794e9f54800b1f0ce36ea5...

Powered by Google App Engine
This is Rietveld 408576698