Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: src/interpreter/bytecodes.h

Issue 2709533002: Revert of [interpreter] Create custom call opcodes for specific argument counts (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-pipeline.h ('k') | src/interpreter/interpreter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecodes.h
diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h
index 834205a4ed1ca6b13a670f3e55c78c9c719ad7c2..f6085269ffacec4b9c73bdcfe01c6625e24100fb 100644
--- a/src/interpreter/bytecodes.h
+++ b/src/interpreter/bytecodes.h
@@ -154,21 +154,8 @@
/* Call operations */ \
V(Call, AccumulatorUse::kWrite, OperandType::kReg, OperandType::kRegList, \
OperandType::kRegCount, OperandType::kIdx) \
- V(Call0, AccumulatorUse::kWrite, OperandType::kReg, OperandType::kReg, \
- OperandType::kIdx) \
- V(Call1, AccumulatorUse::kWrite, OperandType::kReg, OperandType::kReg, \
- OperandType::kReg, OperandType::kIdx) \
- V(Call2, AccumulatorUse::kWrite, OperandType::kReg, OperandType::kReg, \
- OperandType::kReg, OperandType::kReg, OperandType::kIdx) \
V(CallProperty, AccumulatorUse::kWrite, OperandType::kReg, \
OperandType::kRegList, OperandType::kRegCount, OperandType::kIdx) \
- V(CallProperty0, AccumulatorUse::kWrite, OperandType::kReg, \
- OperandType::kReg, OperandType::kIdx) \
- V(CallProperty1, AccumulatorUse::kWrite, OperandType::kReg, \
- OperandType::kReg, OperandType::kReg, OperandType::kIdx) \
- V(CallProperty2, AccumulatorUse::kWrite, OperandType::kReg, \
- OperandType::kReg, OperandType::kReg, OperandType::kReg, \
- OperandType::kIdx) \
V(CallWithSpread, AccumulatorUse::kWrite, OperandType::kReg, \
OperandType::kRegList, OperandType::kRegCount) \
V(TailCall, AccumulatorUse::kWrite, OperandType::kReg, \
@@ -420,7 +407,7 @@
class V8_EXPORT_PRIVATE Bytecodes final {
public:
// The maximum number of operands a bytecode may have.
- static const int kMaxOperands = 5;
+ static const int kMaxOperands = 4;
// Returns string representation of |bytecode|.
static const char* ToString(Bytecode bytecode);
@@ -634,12 +621,6 @@
// Returns true if the bytecode is a call or a constructor call.
static constexpr bool IsCallOrConstruct(Bytecode bytecode) {
return bytecode == Bytecode::kCall || bytecode == Bytecode::kCallProperty ||
- bytecode == Bytecode::kCall0 ||
- bytecode == Bytecode::kCallProperty0 ||
- bytecode == Bytecode::kCall1 ||
- bytecode == Bytecode::kCallProperty1 ||
- bytecode == Bytecode::kCall2 ||
- bytecode == Bytecode::kCallProperty2 ||
bytecode == Bytecode::kTailCall ||
bytecode == Bytecode::kConstruct ||
bytecode == Bytecode::kCallWithSpread ||
« no previous file with comments | « src/interpreter/bytecode-pipeline.h ('k') | src/interpreter/interpreter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698