[Android Crash Reporting] Componentize MinidumpUploadJobService.java

[Android Crash Reporting] Componentize MinidumpUploadJobService.java

BUG=694884
TEST=compile
R=gsennton@chromium.org, tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2709403003
Cr-Commit-Position: refs/heads/master@{#453805}
Committed: https://chromium.googlesource.com/chromium/src/+/17624e38d397ab67a97f0fbc798c53618988a2f1

[gsennton, 2017-02-24 15:11:04]

Cool, I don't have any comments, maybe I'm not a seasoned enough reviewer yet ;)

lgtm

Thanks Ilya!

[Tobias Sargeant, 2017-02-28 22:30:11]

LGTM. Suggestions below are optional.

https://codereview.chromium.org/2709403003/diff/20001/android_webview/java/sr...
File
android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
(right):

https://codereview.chromium.org/2709403003/diff/20001/android_webview/java/sr...
android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java:110:
.Builder(MINIDUMP_UPLOADING_JOB_ID /* jobId */,
nit: could you please minimise whitespace changes here, for the sake of a
smaller diff?

https://codereview.chromium.org/2709403003/diff/20001/components/minidump_upl...
File
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java
(right):

https://codereview.chromium.org/2709403003/diff/20001/components/minidump_upl...
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java:25:
ContextUtils.initApplicationContext(this.getApplicationContext());
Given that minidump uploader creation is deferred to a derived class, maybe
defer this too, making it a responsibility of createMinidumpUploader, if the
created object needs it?

[Ilya Sherman, 2017-02-28 23:50:53]

https://codereview.chromium.org/2709403003/diff/20001/android_webview/java/sr...
File
android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
(right):

https://codereview.chromium.org/2709403003/diff/20001/android_webview/java/sr...
android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java:110:
.Builder(MINIDUMP_UPLOADING_JOB_ID /* jobId */,
On 2017/02/28 22:30:11, Tobias Sargeant wrote:
> nit: could you please minimise whitespace changes here, for the sake of a
> smaller diff?

This is "git cl format" output, unfortunately.

https://codereview.chromium.org/2709403003/diff/20001/components/minidump_upl...
File
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java
(right):

https://codereview.chromium.org/2709403003/diff/20001/components/minidump_upl...
components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java:25:
ContextUtils.initApplicationContext(this.getApplicationContext());
On 2017/02/28 22:30:11, Tobias Sargeant wrote:
> Given that minidump uploader creation is deferred to a derived class, maybe
> defer this too, making it a responsibility of createMinidumpUploader, if the
> created object needs it?

Good call!  It's actually not the created object that needs it; but it *is*
initialization code that should only happen within a Webview context.  Done.

[Ilya Sherman, 2017-02-28 23:51:03]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2017-02-28 23:51:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
gsennton@chromium.org, tobiasjs@chromium.org
Link to the patchset: https://codereview.chromium.org/2709403003/#ps40001
(title: "Init ContextUtils from Webview implemenation only")

[commit-bot: I haz the power, 2017-02-28 23:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:00:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:00:42]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2017-03-01 01:31:23]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:32:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:59:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488331883645790,
"parent_rev": "ef373c14dc822c44badfd7a359cdb87b631d1a27", "commit_rev":
"17624e38d397ab67a97f0fbc798c53618988a2f1"}

[commit-bot: I haz the power, 2017-03-01 03:00:36]

Description was changed from

==========
[Android Crash Reporting] Componentize MinidumpUploadJobService.java

BUG=694884
TEST=compile
R=gsennton@chromium.org, tobiasjs@chromium.org
==========

to

==========
[Android Crash Reporting] Componentize MinidumpUploadJobService.java

BUG=694884
TEST=compile
R=gsennton@chromium.org, tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2709403003
Cr-Commit-Position: refs/heads/master@{#453805}
Committed:
https://chromium.googlesource.com/chromium/src/+/17624e38d397ab67a97f0fbc798c...
==========

[commit-bot: I haz the power, 2017-03-01 03:00:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/17624e38d397ab67a97f0fbc798c...