[Android Crash Reporting] Componentize MinidumpUploadJobService.java

android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.crash;
 
 import android.annotation.TargetApi;
 import android.app.Service;
 import android.app.job.JobInfo;
 import android.app.job.JobScheduler;
@@ skipping 89 matching lines @@
                 }
             }
             mIsCopying = true;
             return true;
         }
     }
 
     private void scheduleNewJob() {
         JobScheduler jobScheduler = (JobScheduler) getSystemService(Context.JOB_SCHEDULER_SERVICE);
         JobInfo newJob = new JobInfo
-                .Builder(MINIDUMP_UPLOADING_JOB_ID /* jobId */,
-                    new ComponentName(this, MinidumpUploadJobService.class))
-                .setRequiredNetworkType(JobInfo.NETWORK_TYPE_UNMETERED)
-                // Minimum delay when a job is retried (a retry will happen when there are minidumps
-                // left after trying to upload all minidumps - this could e.g. happen if we add more
-                // minidumps at the same time as uploading old ones).
-                .setBackoffCriteria(JOB_BACKOFF_TIME_IN_MS, JOB_BACKOFF_POLICY)
-                .build();
+                                 .Builder(MINIDUMP_UPLOADING_JOB_ID /* jobId */,

[Tobias Sargeant, 2017/02/28 22:30:11]

nit: could you please minimise whitespace changes here, for the sake of a
smaller diff?

[Ilya Sherman, 2017/02/28 23:50:53]

This is "git cl format" output, unfortunately.

+                                         new ComponentName(this, AwMinidumpUploadJobService.class))
+                                 .setRequiredNetworkType(JobInfo.NETWORK_TYPE_UNMETERED)
+                                 // Minimum delay when a job is retried (a retry will happen when
+                                 // there are minidumps left after trying to upload all minidumps -
+                                 // this could e.g. happen if we add more minidumps at the same time
+                                 // as uploading old ones).
+                                 .setBackoffCriteria(JOB_BACKOFF_TIME_IN_MS, JOB_BACKOFF_POLICY)
+                                 .build();
         if (jobScheduler.schedule(newJob) == JobScheduler.RESULT_FAILURE) {
             throw new RuntimeException("couldn't schedule " + newJob);
         }
     }
 
     /**
      * Copy minidumps from the {@param fileDescriptors} to the directory where WebView stores its
      * minidump files. {@param context} is used to look up the directory in which the files will be
      * saved.
      * @return whether any minidump was copied.
@@ skipping 82 matching lines @@
     @VisibleForTesting
     public static File getWebViewTmpCrashDir(Context context) {
         return new File(context.getCacheDir(), WEBVIEW_TMP_CRASH_DIR);
     }
 
     @Override
     public IBinder onBind(Intent intent) {
         return mBinder;
     }
 }