Change security checks on scheduled actions to DCHECKs.

Change security checks on scheduled actions to DCHECKs.

BUG=693695, 694446, 695336
Review-Url: https://codereview.chromium.org/2709383003
Cr-Commit-Position: refs/heads/master@{#452611}
Committed: https://chromium.googlesource.com/chromium/src/+/9a1bc1be11daef8aa12a72251bb7c9f9ca75cc36

[Will Harris, 2017-02-23 19:08:41]

Description was changed from

==========
Change security checks to scheduled actions to DCHECKs.

BUG=693695, 694446, 695336
==========

to

==========
Change security checks to scheduled actions to DCHECKs.

BUG=693695, 694446, 695336
==========

[Will Harris, 2017-02-23 19:08:42]

wfh@chromium.org changed reviewers:
+ jochen@chromium.org

[Will Harris, 2017-02-23 19:08:50]

Description was changed from

==========
Change security checks to scheduled actions to DCHECKs.

BUG=693695, 694446, 695336
==========

to

==========
Change security checks on scheduled actions to DCHECKs.

BUG=693695, 694446, 695336
==========

[Will Harris, 2017-02-23 19:09:00]

PTAL

[jochen (gone - plz use gerrit), 2017-02-23 19:10:10]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-02-23 19:10:11]

lgtm

[commit-bot: I haz the power, 2017-02-23 19:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:40:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487877010714930, "parent_rev":
"b7e1925f5dc51dcd72c91edf8be38006a6e051a3", "commit_rev":
"9a1bc1be11daef8aa12a72251bb7c9f9ca75cc36"}

[commit-bot: I haz the power, 2017-02-23 20:40:53]

Description was changed from

==========
Change security checks on scheduled actions to DCHECKs.

BUG=693695, 694446, 695336
==========

to

==========
Change security checks on scheduled actions to DCHECKs.

BUG=693695, 694446, 695336

Review-Url: https://codereview.chromium.org/2709383003
Cr-Commit-Position: refs/heads/master@{#452611}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a1bc1be11daef8aa12a72251bb7...
==========

[commit-bot: I haz the power, 2017-02-23 20:40:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a1bc1be11daef8aa12a72251bb7...

[haraken, 2017-02-23 21:31:00]

LGTM but it would be nicer to explain why you want to replace CHECK with DCHECK
in the CL description.

[Will Harris, 2017-02-23 21:33:14]

For the record, jochen asked me to land this since he was OOO and his revert of
the CL that added the CHECK wasn't cleanly reverting. I think he plans to
actually fix this at a later date.

[haraken, 2017-02-23 21:34:38]

On 2017/02/23 21:33:14, Will Harris wrote:
> For the record, jochen asked me to land this since he was OOO and his revert
of
> the CL that added the CHECK wasn't cleanly reverting. I think he plans to
> actually fix this at a later date.

Yeah, I think the DCHECK is still problematic (although it is less likely to hit
because DCHECK is not enabled on production builds).

[Will Harris, 2017-02-23 21:42:40]

I think this was the stopgap for Canary, while jochen worked on the real fix
(once he was not OOO). If the straight revert of the CL had landed then we would
have just landed that.

[haraken, 2017-02-23 21:44:30]

On 2017/02/23 21:42:40, Will Harris wrote:
> I think this was the stopgap for Canary, while jochen worked on the real fix
> (once he was not OOO). If the straight revert of the CL had landed then we
would
> have just landed that.

Thanks, I guess a right fix would be just remove the DCHECK entirely... until
jochen supports a microtask execution :)