Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Issue 2709383003: Change security checks on scheduled actions to DCHECKs. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
index a84d288607e9a7e17d3355500fd5f8f79dd1d362..1f40c6b0867dbdae9df028e20926770b48a1c814 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
@@ -52,7 +52,7 @@ ScheduledAction* ScheduledAction::create(ScriptState* scriptState,
const Vector<ScriptValue>& arguments) {
ASSERT(handler.isFunction());
if (!scriptState->world().isWorkerWorld()) {
- CHECK(BindingSecurity::shouldAllowAccessToFrame(
+ DCHECK(BindingSecurity::shouldAllowAccessToFrame(
enteredDOMWindow(scriptState->isolate()), toDocument(target)->frame(),
BindingSecurity::ErrorReportOption::DoNotReport));
}
@@ -63,7 +63,7 @@ ScheduledAction* ScheduledAction::create(ScriptState* scriptState,
ExecutionContext* target,
const String& handler) {
if (!scriptState->world().isWorkerWorld()) {
- CHECK(BindingSecurity::shouldAllowAccessToFrame(
+ DCHECK(BindingSecurity::shouldAllowAccessToFrame(
enteredDOMWindow(scriptState->isolate()), toDocument(target)->frame(),
BindingSecurity::ErrorReportOption::DoNotReport));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698