Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Issue 2709343002: Fix bug on Android causing composition underlines to appear in the wrong place (Closed)

Created:
3 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix bug on Android causing composition underlines to appear in the wrong place The previous code I introduced in DocumentMarkerController::setComposition() was passing an offset measured in DOM children to addCompositionUnderlines() (and it wasn't even measured correctly) when it should have been passing an offset measured in plain text characters. Oops I'd like to add a test case for this bug, unfortunately I'm having trouble reproducing it in a test. BUG=692699 Review-Url: https://codereview.chromium.org/2689233006 Cr-Commit-Position: refs/heads/master@{#451903} (cherry picked from commit 6923513dcedf4c6b55bc923fc0146aff71b3da46) Review-Url: https://codereview.chromium.org/2709343002 . Cr-Commit-Position: refs/branch-heads/2987@{#646} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/21aa8273bfcc29e0a7048213f667a0542451fa8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 10 months ago (2017-02-22 22:07:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21aa8273bfcc29e0a7048213f667a0542451fa8c.

Powered by Google App Engine
This is Rietveld 408576698