Fix bug on Android causing composition underlines to appear in the wrong place

Fix bug on Android causing composition underlines to appear in the wrong place

The previous code I introduced in DocumentMarkerController::setComposition()
was passing an offset measured in DOM children to addCompositionUnderlines()
(and it wasn't even measured correctly) when it should have been passing an
offset measured in plain text characters. Oops

I'd like to add a test case for this bug, unfortunately I'm having trouble
reproducing it in a test.

BUG=692699
Review-Url: https://codereview.chromium.org/2689233006
Cr-Commit-Position: refs/heads/master@{#451903}
Committed: https://chromium.googlesource.com/chromium/src/+/6923513dcedf4c6b55bc923fc0146aff71b3da46

[rlanday, 2017-02-16 00:35:29]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-02-16 00:36:04]

rlanday@chromium.org changed reviewers:
+ yosin@chromium.org

[rlanday, 2017-02-16 00:36:04]

rlanday@chromium.org changed required reviewers:
+ yosin@chromium.org

[rlanday, 2017-02-16 00:36:37]

Bug fix for a regression I introduced: crbug.com/692699

[commit-bot: I haz the power, 2017-02-16 00:36:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-02-16 00:37:54]

https://codereview.chromium.org/2689233006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/2689233006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:612:
addCompositionUnderlines(underlines, baseNode->parentNode(),
Unfortunately I can't just work with baseNode directly here because it's not
necessarily a ContainerNode, so I'm using the parent instead and getting the
composition's plain text offset to the parent.

[rlanday, 2017-02-16 02:10:12]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 02:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 07:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 07:03:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-02-17 18:32:22]

Note: I think this CL will need to be picked for version 57 since the bug was
introduced before the branch cut (January 19):
https://chromium.googlesource.com/chromium/src/+/7efe230106176ba759388532a099...

[yosin_UTC9, 2017-02-20 06:29:10]

https://codereview.chromium.org/2689233006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right):

https://codereview.chromium.org/2689233006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:355:
ContainerNode* baseElement,
Please do renaming in another patch for ease of reviewing.
It is hard to identify which change fix the issue.

https://codereview.chromium.org/2689233006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/InputMethodController.cpp:610:
PlainTextRange compositionPlainTextRange =
nit: s/PlainTextRange/const PlainTextRange/

[rlanday, 2017-02-21 19:17:25]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 19:18:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-02-21 19:25:58]

Ok, I've made the requested changes

[commit-bot: I haz the power, 2017-02-21 21:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:22:20]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[yosin_UTC9, 2017-02-22 06:51:28]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-02-22 06:51:29]

lgtm

[commit-bot: I haz the power, 2017-02-22 06:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 06:57:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487746288445700,
"parent_rev": "479ccd4b4d85396ed50eed8ce07b1b7dd9199109", "commit_rev":
"6923513dcedf4c6b55bc923fc0146aff71b3da46"}

[commit-bot: I haz the power, 2017-02-22 06:58:13]

Description was changed from

==========
Fix bug on Android causing composition underlines to appear in the wrong place

The previous code I introduced in DocumentMarkerController::setComposition()
was passing an offset measured in DOM children to addCompositionUnderlines()
(and it wasn't even measured correctly) when it should have been passing an
offset measured in plain text characters. Oops

I'd like to add a test case for this bug, unfortunately I'm having trouble
reproducing it in a test.

BUG=692699
==========

to

==========
Fix bug on Android causing composition underlines to appear in the wrong place

The previous code I introduced in DocumentMarkerController::setComposition()
was passing an offset measured in DOM children to addCompositionUnderlines()
(and it wasn't even measured correctly) when it should have been passing an
offset measured in plain text characters. Oops

I'd like to add a test case for this bug, unfortunately I'm having trouble
reproducing it in a test.

BUG=692699

Review-Url: https://codereview.chromium.org/2689233006
Cr-Commit-Position: refs/heads/master@{#451903}
Committed:
https://chromium.googlesource.com/chromium/src/+/6923513dcedf4c6b55bc923fc014...
==========

[commit-bot: I haz the power, 2017-02-22 06:58:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6923513dcedf4c6b55bc923fc014...