Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2709313003: Revert of [inspector] use BREAK_POSITION_ALIGNED for breakpoints (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
Reviewers:
kozy, dgozman, Yang
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] use BREAK_POSITION_ALIGNED for breakpoints (patchset #7 id:120001 of https://codereview.chromium.org/2709263002/ ) Reason for revert: breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13747 which blocks rolling. See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] use BREAK_POSITION_ALIGNED for breakpoints > > With inline breakpoints DevTools are ready for break position aligned breakpoints instead of statement aligned. > > BUG=chromium:695236 > R=dgozman@chromium.org,yangguo@chromium.org > > Review-Url: https://codereview.chromium.org/2709263002 > Cr-Commit-Position: refs/heads/master@{#43385} > Committed: https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b6ccf0 TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:695236 Review-Url: https://codereview.chromium.org/2709313003 Cr-Commit-Position: refs/heads/master@{#43395} Committed: https://chromium.googlesource.com/v8/v8/+/bdd23acd9253bf7ca1fd5763f8314d673e627c69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1134 lines, -326 lines) Patch
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/debugger-script.js View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/get-possible-breakpoints.js View 3 chunks +93 lines, -123 lines 0 comments Download
M test/inspector/debugger/get-possible-breakpoints-expected.txt View 1 chunk +1038 lines, -200 lines 0 comments Download
M test/inspector/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [inspector] use BREAK_POSITION_ALIGNED for breakpoints
3 years, 10 months ago (2017-02-23 20:26:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709313003/1
3 years, 10 months ago (2017-02-23 20:26:55 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 20:27:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bdd23acd9253bf7ca1fd5763f8314d673e6...

Powered by Google App Engine
This is Rietveld 408576698