[BlobStorage] Better net error reporting for pre-broken blobs

[BlobStorage] Better net error reporting for pre-broken blobs

BUG=688100
Review-Url: https://codereview.chromium.org/2709213003
Cr-Commit-Position: refs/heads/master@{#452326}
Committed: https://chromium.googlesource.com/chromium/src/+/e80397e738255b07d17d508c77acc2a87966f614

[dmurph, 2017-02-22 23:17:34]

dmurph@chromium.org changed reviewers:
+ pwnall@chromium.org

[dmurph, 2017-02-22 23:17:35]

Victor, can you PTAL?

[dmurph, 2017-02-22 23:17:41]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 23:18:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-02-22 23:33:51]

https://codereview.chromium.org/2709213003/diff/1/storage/browser/blob/blob_r...
File storage/browser/blob/blob_reader.cc (right):

https://codereview.chromium.org/2709213003/diff/1/storage/browser/blob/blob_r...
storage/browser/blob/blob_reader.cc:79: if (!blob_handle->IsBroken()) {
How about flipping the if / else, so no (implicit) double negative shows up when
thinking about condition gating the else branch?

[dmurph, 2017-02-22 23:43:07]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[dmurph, 2017-02-22 23:43:25]

https://codereview.chromium.org/2709213003/diff/1/storage/browser/blob/blob_r...
File storage/browser/blob/blob_reader.cc (right):

https://codereview.chromium.org/2709213003/diff/1/storage/browser/blob/blob_r...
storage/browser/blob/blob_reader.cc:79: if (!blob_handle->IsBroken()) {
On 2017/02/22 23:33:50, pwnall wrote:
> How about flipping the if / else, so no (implicit) double negative shows up
when
> thinking about condition gating the else branch?
> 

Good idea, thanks.

[commit-bot: I haz the power, 2017-02-22 23:43:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-02-23 00:01:28]

lgtm

[dmurph, 2017-02-23 00:01:44]

The CQ bit was unchecked by dmurph@chromium.org

[dmurph, 2017-02-23 00:01:48]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2017-02-23 00:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 01:21:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487808108360500,
"parent_rev": "4f6b7bc7f2da4ae1813936fb341d4ed9ecbaeee8", "commit_rev":
"e80397e738255b07d17d508c77acc2a87966f614"}

[commit-bot: I haz the power, 2017-02-23 01:22:39]

Description was changed from

==========
[BlobStorage] Better net error reporting for pre-broken blobs

BUG=688100
==========

to

==========
[BlobStorage] Better net error reporting for pre-broken blobs

BUG=688100

Review-Url: https://codereview.chromium.org/2709213003
Cr-Commit-Position: refs/heads/master@{#452326}
Committed:
https://chromium.googlesource.com/chromium/src/+/e80397e738255b07d17d508c77ac...
==========

[commit-bot: I haz the power, 2017-02-23 01:22:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e80397e738255b07d17d508c77ac...