storage/browser/blob/blob_reader.cc - Issue 2709213003: [BlobStorage] Better net error reporting for pre-broken blobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_reader.cc

Issue 2709213003: [BlobStorage] Better net error reporting for pre-broken blobs (Closed)

Patch Set: switched to avoid double negative Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/blob/blob_reader.cc

diff --git a/storage/browser/blob/blob_reader.cc b/storage/browser/blob/blob_reader.cc

index 5584036d348d50a96e31964f6ff41237893b7a7a..2d486872d6305c71f8f945730adf83ac1c2699a4 100644

--- a/storage/browser/blob/blob_reader.cc

+++ b/storage/browser/blob/blob_reader.cc

@@ -75,8 +75,12 @@ BlobReader::BlobReader(

file_task_runner_(file_task_runner),

net_error_(net::OK),

weak_factory_(this) {

- if (blob_handle && !blob_handle->IsBroken()) {

- blob_handle_.reset(new BlobDataHandle(*blob_handle));

+ if (blob_handle) {

+ if (blob_handle->IsBroken()) {

+ net_error_ = ConvertBlobErrorToNetError(blob_handle->GetBlobStatus());

+ } else {

+ blob_handle_.reset(new BlobDataHandle(*blob_handle));

+ }

}