Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: sandbox/linux/tests/unit_tests.cc

Issue 2709203002: sandbox tests: Adapt test expectations to new CHECK() behavior (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/syscall_broker/broker_file_permission_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/tests/unit_tests.cc
diff --git a/sandbox/linux/tests/unit_tests.cc b/sandbox/linux/tests/unit_tests.cc
index 660053b5845bf2170e50c6eb69bb22788802ddf7..efe2896618fbaf87286ef7f608a4e0840dc29c85 100644
--- a/sandbox/linux/tests/unit_tests.cc
+++ b/sandbox/linux/tests/unit_tests.cc
@@ -288,14 +288,14 @@ void UnitTests::DeathMessage(int status,
bool subprocess_exited_without_matching_message =
msg.find(expected_msg) == std::string::npos;
-// In official builds CHECK messages are dropped, so look for SIGABRT or SIGILL.
+// In official builds CHECK messages are dropped, look for SIGABRT or SIGTRAP.
// See https://crbug.com/437312 and https://crbug.com/612507.
#if defined(OFFICIAL_BUILD) && defined(NDEBUG) && !defined(OS_ANDROID)
if (subprocess_exited_without_matching_message) {
- static const char kSigIllegalMessage[] = "Received signal 4";
+ static const char kSigTrapMessage[] = "Received signal 5";
static const char kSigAbortMessage[] = "Received signal 6";
subprocess_exited_without_matching_message =
- msg.find(kSigIllegalMessage) == std::string::npos &&
+ msg.find(kSigTrapMessage) == std::string::npos &&
msg.find(kSigAbortMessage) == std::string::npos;
}
#endif
« no previous file with comments | « sandbox/linux/syscall_broker/broker_file_permission_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698