Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2709153004: Use video profile to decide if we should produce fp16 textures. (Closed)

Created:
3 years, 10 months ago by hubbe
Modified:
3 years, 10 months ago
Reviewers:
jbauman
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use video profile to decide if we should produce fp16 textures. For video profiles with more than 8 bits, use fp16 textures if supported so that we don't loose accuracy. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2709153004 Cr-Commit-Position: refs/heads/master@{#452618} Committed: https://chromium.googlesource.com/chromium/src/+/27aabb44f4320bcd7e6b01d33cc1649e2f955194

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -17 lines) Patch
M media/gpu/dxva_picture_buffer_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 5 chunks +46 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
hubbe
3 years, 10 months ago (2017-02-23 01:39:55 UTC) #4
jbauman
lgtm with a couple of nits. https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode_accelerator_win.cc File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode_accelerator_win.cc#newcode1534 media/gpu/dxva_video_decode_accelerator_win.cc:1534: LOG(ERROR) << "EGL..."; ...
3 years, 10 months ago (2017-02-23 02:01:46 UTC) #6
hubbe
https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode_accelerator_win.cc File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode_accelerator_win.cc#newcode1534 media/gpu/dxva_video_decode_accelerator_win.cc:1534: LOG(ERROR) << "EGL..."; On 2017/02/23 02:01:46, jbauman wrote: > ...
3 years, 10 months ago (2017-02-23 19:26:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709153004/20001
3 years, 10 months ago (2017-02-23 19:27:37 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 20:50:49 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27aabb44f4320bcd7e6b01d33cc1...

Powered by Google App Engine
This is Rietveld 408576698