Use video profile to decide if we should produce fp16 textures.

Use video profile to decide if we should produce fp16 textures.

For video profiles with more than 8 bits, use fp16 textures if supported
so that we don't loose accuracy.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2709153004
Cr-Commit-Position: refs/heads/master@{#452618}
Committed: https://chromium.googlesource.com/chromium/src/+/27aabb44f4320bcd7e6b01d33cc1649e2f955194

[hubbe, 2017-02-23 01:39:19]

Description was changed from

==========
Use video profile to decide if we should produce fp16 textures.

For video profiles with more than 8 bits, use fp16 textures if supported
so that we don't loose accuracy.

BUG=682416
==========

to

==========
Use video profile to decide if we should produce fp16 textures.

For video profiles with more than 8 bits, use fp16 textures if supported
so that we don't loose accuracy.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hubbe, 2017-02-23 01:39:29]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[hubbe, 2017-02-23 01:39:55]

hubbe@chromium.org changed reviewers:
+ jbauman@chromium.org

[commit-bot: I haz the power, 2017-02-23 01:40:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-02-23 02:01:46]

lgtm with a couple of nits.

https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:1534: LOG(ERROR) << "EGL...";
Remove.

https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:1546: if
(!eglChooseConfig(egl_display, config_attribs, &egl_config_, 1,
I think this should check if num_configs == 0 as well.

[commit-bot: I haz the power, 2017-02-23 03:09:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 03:09:42]

Dry run: This issue passed the CQ dry run.

[hubbe, 2017-02-23 19:21:59]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 19:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-02-23 19:26:09]

https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:1534: LOG(ERROR) << "EGL...";
On 2017/02/23 02:01:46, jbauman wrote:
> Remove.

Done.

https://codereview.chromium.org/2709153004/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:1546: if
(!eglChooseConfig(egl_display, config_attribs, &egl_config_, 1,
On 2017/02/23 02:01:46, jbauman wrote:
> I think this should check if num_configs == 0 as well.

Done.

[hubbe, 2017-02-23 19:26:51]

The CQ bit was unchecked by hubbe@chromium.org

[hubbe, 2017-02-23 19:27:08]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2017-02-23 19:27:09]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2709153004/#ps20001
(title: "comments addressed")

[commit-bot: I haz the power, 2017-02-23 19:27:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:50:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487878028662860,
"parent_rev": "b97c0922116dbeb62d81790daf475495a399d264", "commit_rev":
"27aabb44f4320bcd7e6b01d33cc1649e2f955194"}

[commit-bot: I haz the power, 2017-02-23 20:50:46]

Description was changed from

==========
Use video profile to decide if we should produce fp16 textures.

For video profiles with more than 8 bits, use fp16 textures if supported
so that we don't loose accuracy.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use video profile to decide if we should produce fp16 textures.

For video profiles with more than 8 bits, use fp16 textures if supported
so that we don't loose accuracy.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2709153004
Cr-Commit-Position: refs/heads/master@{#452618}
Committed:
https://chromium.googlesource.com/chromium/src/+/27aabb44f4320bcd7e6b01d33cc1...
==========

[commit-bot: I haz the power, 2017-02-23 20:50:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27aabb44f4320bcd7e6b01d33cc1...