Fix specifier simplification and add test.

Fix specifier simplification and add test.

There was still a bug left in logic for simplifying the specifier
list for new test expectation lines: specifiers for skipped tests
were added after simplification, meaning that in the (common) case
where the test fails the same on all platforms and android is skipped,
the specifier list is simplified to [ Linux Mac Win ] and then
Android is added.

The fix is to add specifiers for skipped ports before simplifying.

BUG=655201
Review-Url: https://codereview.chromium.org/2709103009
Cr-Commit-Position: refs/heads/master@{#453284}
Committed: https://chromium.googlesource.com/chromium/src/+/3e6f43b480f54b4abe4b8a9e8d7e95abec31c2db

[qyearsley, 2017-02-24 19:52:44]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 19:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:16:35]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-02-24 22:33:20]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-02-26 19:22:26]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 19:22:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 20:28:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 20:28:42]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2017-02-27 18:57:36]

lgtm

[qyearsley, 2017-02-27 19:00:42]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-02-27 19:01:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:12:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488222042069380,
"parent_rev": "f3303da50d08471efcb8ddf8db61c4d60aebee7a", "commit_rev":
"3e6f43b480f54b4abe4b8a9e8d7e95abec31c2db"}

[commit-bot: I haz the power, 2017-02-27 19:13:14]

Description was changed from

==========
Fix specifier simplification and add test.

There was still a bug left in logic for simplifying the specifier
list for new test expectation lines: specifiers for skipped tests
were added after simplification, meaning that in the (common) case
where the test fails the same on all platforms and android is skipped,
the specifier list is simplified to [ Linux Mac Win ] and then
Android is added.

The fix is to add specifiers for skipped ports before simplifying.

BUG=655201
==========

to

==========
Fix specifier simplification and add test.

There was still a bug left in logic for simplifying the specifier
list for new test expectation lines: specifiers for skipped tests
were added after simplification, meaning that in the (common) case
where the test fails the same on all platforms and android is skipped,
the specifier list is simplified to [ Linux Mac Win ] and then
Android is added.

The fix is to add specifiers for skipped ports before simplifying.

BUG=655201

Review-Url: https://codereview.chromium.org/2709103009
Cr-Commit-Position: refs/heads/master@{#453284}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e6f43b480f54b4abe4b8a9e8d7e...
==========

[commit-bot: I haz the power, 2017-02-27 19:13:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e6f43b480f54b4abe4b8a9e8d7e...