third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py - Issue 2709103009: Fix specifier simplification and add test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

Issue 2709103009: Fix specifier simplification and add test. (Closed)

Patch Set: Remove print statements, set MockPortFactory in mock_host method. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

index e65d5e6cbcaf5abb2b7c927862d993a19d7b5eca..fc8f37b3f12c9911fb6bff306b7eac1dc9119af1 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

@@ -279,8 +279,8 @@ class WPTExpectationsUpdater(object):

for name in sorted(port_names):

specifiers.append(self.host.builders.version_specifier_for_port_name(name))

port = self.host.port_factory.get()

- specifiers = self.simplify_specifiers(specifiers, port.configuration_specifier_macros())

specifiers.extend(self.skipped_specifiers(test_name))

+ specifiers = self.simplify_specifiers(specifiers, port.configuration_specifier_macros())

if not specifiers:

return ''

return '[ %s ]' % ' '.join(specifiers)