Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2709103006: Remove check for Galaxy S5s from BattOrBenchmark's ShouldDisable (Closed)

Created:
3 years, 10 months ago by charliea (OOO until 10-5)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove check for Galaxy S5s from BattOrBenchmark's ShouldDisable It's no longer necessary now that we've removed the S5s from the perf waterfall. Review-Url: https://codereview.chromium.org/2709103006 Cr-Commit-Position: refs/heads/master@{#453223} Committed: https://chromium.googlesource.com/chromium/src/+/65fa5e5cce6c1e7dcb4947a26d6d219796da0dd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M tools/perf/benchmarks/battor.py View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
charliea (OOO until 10-5)
3 years, 10 months ago (2017-02-23 18:48:06 UTC) #2
rnephew (Reviews Here)
On 2017/02/23 18:48:06, charliea wrote: nonowner lgtm
3 years, 10 months ago (2017-02-23 19:05:30 UTC) #3
nednguyen
lgtm
3 years, 10 months ago (2017-02-23 19:23:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709103006/1
3 years, 9 months ago (2017-02-27 14:29:15 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 15:53:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65fa5e5cce6c1e7dcb4947a26d6d...

Powered by Google App Engine
This is Rietveld 408576698