Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/battor.py

Issue 2709103006: Remove check for Galaxy S5s from BattOrBenchmark's ShouldDisable (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/battor.py
diff --git a/tools/perf/benchmarks/battor.py b/tools/perf/benchmarks/battor.py
index 3ba750aefd9b140839e5ad75c5fe8dbbd7d5b788..a859e756cd0a91dc7aed3c80f1023e604e291553 100644
--- a/tools/perf/benchmarks/battor.py
+++ b/tools/perf/benchmarks/battor.py
@@ -29,14 +29,7 @@ class _BattOrBenchmark(perf_benchmark.PerfBenchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
- # Only run if BattOr is detected.
- if not possible_browser.platform.HasBattOrConnected():
- return True
-
- # Galaxy S5s have problems with running system health metrics.
- # http://crbug.com/600463
- galaxy_s5_type_name = 'SM-G900H'
- return possible_browser.platform.GetDeviceTypeName() == galaxy_s5_type_name
+ return not possible_browser.platform.HasBattOrConnected()
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698