[Content] Allow V8ValueConverter to convert -0 to an integer

[Content] Allow V8ValueConverter to convert -0 to an integer

V8ValueConverter currently converts -0 to a double, because it is not
considered an int32 (or a uint32), even though it is === 0 (which is
considered an int). This causes nastiness in extensions because we
evaluate it as an integer, but the V8ValueConverter converts it to a
bool, and breaks our expectations.

Add a configuration method, SetConvertNegativeZeroToInt(), to
V8ValueConverter to specify that -0 should be converted to an
int.

Add tests for both scenarios (with and without the configuration).

BUG=694248
Review-Url: https://codereview.chromium.org/2709103004
Cr-Commit-Position: refs/heads/master@{#452854}
Committed: https://chromium.googlesource.com/chromium/src/+/f88f9bc261af492194bc6d3b2e3536adc2a34904

[Devlin, 2017-02-22 20:26:05]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 20:27:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-02-22 21:50:41]

Description was changed from

==========
-0
BUG=694248
==========

to

==========
[Content] Allow V8ValueConverter to convert -0 to an integer

V8ValueConverter currently converts -0 to a double, because it is not
considered an int32 (or a uint32), even though it is === 0 (which is
considered an int). This causes nastiness in extensions because we
evaluate it as an integer, but the V8ValueConverter converts it to a
bool, and breaks our expectations.

Add a configuration method, SetConvertNegativeZeroToInt(), to
V8ValueConverter to specify that -0 should be converted to an
int.

Add tests for both scenarios (with and without the configuration).

BUG=694248
==========

[Devlin, 2017-02-22 21:52:15]

rdevlin.cronin@chromium.org changed reviewers:
+ jochen@chromium.org

[Devlin, 2017-02-22 21:52:16]

jochen@, mind taking a look?

Technically, we could do this with the
V8ValueConverter::Strategy::FromV8Number() method instead, but that seems a lot
heavier-weight than we need.

[commit-bot: I haz the power, 2017-02-22 22:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:05:16]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-02-24 15:57:02]

lgtm

[Devlin, 2017-02-24 16:02:38]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-02-24 16:02:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 17:09:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487952158527340, "parent_rev":
"633a30085db403a43d935bd5e6a9f3eb1053bc85", "commit_rev":
"f88f9bc261af492194bc6d3b2e3536adc2a34904"}

[commit-bot: I haz the power, 2017-02-24 17:10:09]

Description was changed from

==========
[Content] Allow V8ValueConverter to convert -0 to an integer

V8ValueConverter currently converts -0 to a double, because it is not
considered an int32 (or a uint32), even though it is === 0 (which is
considered an int). This causes nastiness in extensions because we
evaluate it as an integer, but the V8ValueConverter converts it to a
bool, and breaks our expectations.

Add a configuration method, SetConvertNegativeZeroToInt(), to
V8ValueConverter to specify that -0 should be converted to an
int.

Add tests for both scenarios (with and without the configuration).

BUG=694248
==========

to

==========
[Content] Allow V8ValueConverter to convert -0 to an integer

V8ValueConverter currently converts -0 to a double, because it is not
considered an int32 (or a uint32), even though it is === 0 (which is
considered an int). This causes nastiness in extensions because we
evaluate it as an integer, but the V8ValueConverter converts it to a
bool, and breaks our expectations.

Add a configuration method, SetConvertNegativeZeroToInt(), to
V8ValueConverter to specify that -0 should be converted to an
int.

Add tests for both scenarios (with and without the configuration).

BUG=694248

Review-Url: https://codereview.chromium.org/2709103004
Cr-Commit-Position: refs/heads/master@{#452854}
Committed:
https://chromium.googlesource.com/chromium/src/+/f88f9bc261af492194bc6d3b2e35...
==========

[commit-bot: I haz the power, 2017-02-24 17:10:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f88f9bc261af492194bc6d3b2e35...