extensions/renderer/resources/schema_utils.js - Issue 2709103004: [Content] Allow V8ValueConverter to convert -0 to an integer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/schema_utils.js

Issue 2709103004: [Content] Allow V8ValueConverter to convert -0 to an integer (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/schema_utils.js

diff --git a/extensions/renderer/resources/schema_utils.js b/extensions/renderer/resources/schema_utils.js

index 1d1023a00b2502132aeacce4bbf96e5c7dfaa246..8f8e26ab0ddd48f8caba8cdbfb87403a2f68be74 100644

--- a/extensions/renderer/resources/schema_utils.js

+++ b/extensions/renderer/resources/schema_utils.js

@@ -117,9 +117,6 @@ function normalizeArgumentsAndValidate(args, funDef) {

var normalizedArgs = [];

var ai = 0;

for (var si = 0; si < definedSignature.length; ++si) {

- // Handle integer -0 as 0.

- if (JSONSchemaValidator.getType(args[ai]) === 'integer' && args[ai] === 0)

- args[ai] = 0;

if (definedSignature[si] === resolvedSignature[ai])

$Array.push(normalizedArgs, args[ai++]);

else