idl_parser: Always use PLY from third_party.

idl_parser: Always use PLY from third_party.

Stop trying to import PLY from a system installation and preferring it over
the version in third_party: doing so brings the risk of incompatibilities,
especially when running the unit tests.

See https://codereview.chromium.org/2704653002/, for example, where the
errors remain the same, but the structure output by PLY is different.

R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2708803003
Cr-Commit-Position: refs/heads/master@{#451742}
Committed: https://chromium.googlesource.com/chromium/src/+/adf0559c06874185a1eb8f27a46871477d7ab0d9

[Raphael Kubo da Costa (rakuco), 2017-02-21 10:24:16]

PTAL.

This is the reason I was getting different test expectations in
https://codereview.chromium.org/2704653002/: I have a different PLY version
installed system-wide which was getting chosen when I was running idl_parser's
tests.

[haraken, 2017-02-21 10:29:08]

LGTM

[Raphael Kubo da Costa (rakuco), 2017-02-21 10:35:50]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-02-21 10:36:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-02-21 10:39:26]

LGTM.

This is what bashi@ was suspicious about.  bashi@ is off tomorrow, and I think
you don't need to wait their LGTM.

https://codereview.chromium.org/2708803003/diff/1/tools/idl_parser/idl_lexer.py
File tools/idl_parser/idl_lexer.py (right):

https://codereview.chromium.org/2708803003/diff/1/tools/idl_parser/idl_lexer....
tools/idl_parser/idl_lexer.py:21: sys.path = [os.path.join(SRC_DIR,
'third_party')] + sys.path
nit: sys.path.insert(0, third_party's dir) would be cleaner.

[Raphael Kubo da Costa (rakuco), 2017-02-21 10:41:33]

The CQ bit was unchecked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-02-21 10:43:40]

Thanks, I've uploaded patch v2 using sys.path.insert(). I'll re-check the CQ box
to land it.

[Raphael Kubo da Costa (rakuco), 2017-02-21 10:43:45]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-02-21 10:43:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2708803003/#ps20001
(title: "Use sys.path.insert()")

[commit-bot: I haz the power, 2017-02-21 10:44:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 11:53:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 11:53:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raphael Kubo da Costa (rakuco), 2017-02-21 11:56:19]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-02-21 11:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 12:58:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487678179178250,
"parent_rev": "06b09f98b83b06cdc7879af14022c54db54f4d61", "commit_rev":
"adf0559c06874185a1eb8f27a46871477d7ab0d9"}

[commit-bot: I haz the power, 2017-02-21 12:59:05]

Description was changed from

==========
idl_parser: Always use PLY from third_party.

Stop trying to import PLY from a system installation and preferring it over
the version in third_party: doing so brings the risk of incompatibilities,
especially when running the unit tests.

See https://codereview.chromium.org/2704653002/, for example, where the
errors remain the same, but the structure output by PLY is different.

R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
idl_parser: Always use PLY from third_party.

Stop trying to import PLY from a system installation and preferring it over
the version in third_party: doing so brings the risk of incompatibilities,
especially when running the unit tests.

See https://codereview.chromium.org/2704653002/, for example, where the
errors remain the same, but the structure output by PLY is different.

R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2708803003
Cr-Commit-Position: refs/heads/master@{#451742}
Committed:
https://chromium.googlesource.com/chromium/src/+/adf0559c06874185a1eb8f27a468...
==========

[commit-bot: I haz the power, 2017-02-21 12:59:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/adf0559c06874185a1eb8f27a468...

[bashi, 2017-02-21 13:50:15]

lgtm. Thanks yukishiino@ for the follow-up!