Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2704653002: idl_parser: Fix test expectations. (Closed)

Created:
3 years, 10 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 10 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

idl_parser: Fix test expectations. Adjust some failure expectations so they match what the tests are actually producing these days. It is unclear when the output changed, but the error message remains the same. R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M tools/idl_parser/test_parser/dictionary_web.idl View 1 chunk +1 line, -7 lines 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Raphael Kubo da Costa (rakuco)
PTAL. From a quick look, I got the impression that these tests are not being ...
3 years, 10 months ago (2017-02-17 10:19:57 UTC) #1
haraken
bashi-san?
3 years, 10 months ago (2017-02-17 10:24:18 UTC) #2
bashi
On 2017/02/17 10:24:18, haraken wrote: > bashi-san? lgtm. Thanks for the fix!
3 years, 10 months ago (2017-02-18 01:50:29 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-18 02:24:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704653002/1
3 years, 10 months ago (2017-02-18 11:06:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/367983)
3 years, 10 months ago (2017-02-18 11:12:58 UTC) #8
Raphael Kubo da Costa (rakuco)
Sigh. The new expectations make the tests pass here on Fedora, but break Ubuntu Trusty ...
3 years, 10 months ago (2017-02-20 18:58:22 UTC) #9
Raphael Kubo da Costa (rakuco)
3 years, 10 months ago (2017-02-21 10:24:36 UTC) #10
On 2017/02/20 18:58:22, Raphael Kubo da Costa (rakuco) wrote:
> Sigh. The new expectations make the tests pass here on Fedora, but break
Ubuntu
> Trusty (I've also reproduced this on an Ubuntu VM) and vice-versa. I'll have
to
> dig deeper into this.

Done in https://codereview.chromium.org/2708803003/. I'll close this CL.

Powered by Google App Engine
This is Rietveld 408576698