Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2708763002: Revert of Selection API: collapseToStart() and collapseToEnd() should recreate a Range. (Closed)

Created:
3 years, 10 months ago by cfroussios
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Selection API: collapseToStart() and collapseToEnd() should recreate a Range. (patchset #3 id:40001 of https://codereview.chromium.org/2704963002/ ) Reason for revert: Suspected cause of failure Test: fast/css/first-letter-rtc-crash.html See bug http://crbug.com/694307 Original issue's description: > Selection API: collapseToStart() and collapseToEnd() should recreate a Range. > > This CL fixes 46 tests in external/wpt/selection/. > > BUG=692400 > > Review-Url: https://codereview.chromium.org/2704963002 > Cr-Commit-Position: refs/heads/master@{#451630} > Committed: https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b8c33b2f3b486 TBR=yosin@chromium.org,yoichio@chromium.org,tkent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692400 Review-Url: https://codereview.chromium.org/2708763002 Cr-Commit-Position: refs/heads/master@{#451646} Committed: https://chromium.googlesource.com/chromium/src/+/1de8912f43f6ed0ec035aa46b93ad831b59cbd67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -75 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt View 2 chunks +87 lines, -47 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +12 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
cfroussios
Created Revert of Selection API: collapseToStart() and collapseToEnd() should recreate a Range.
3 years, 10 months ago (2017-02-20 17:52:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708763002/1
3 years, 10 months ago (2017-02-20 17:52:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1de8912f43f6ed0ec035aa46b93ad831b59cbd67
3 years, 10 months ago (2017-02-20 17:53:40 UTC) #6
tkent
3 years, 10 months ago (2017-02-20 22:50:17 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698