Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2704963002: Selection API: collapseToStart() and collapseToEnd() should recreate a Range. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: collapseToStart() and collapseToEnd() should recreate a Range. This CL fixes 46 tests in external/wpt/selection/. BUG=692400 Review-Url: https://codereview.chromium.org/2704963002 Cr-Original-Commit-Position: refs/heads/master@{#451630} Committed: https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b8c33b2f3b486 Review-Url: https://codereview.chromium.org/2704963002 Cr-Commit-Position: refs/heads/master@{#451673} Committed: https://chromium.googlesource.com/chromium/src/+/e80226a3b58c969b6a6c8002ce65bb7e786b96c4

Patch Set 1 #

Patch Set 2 : rebaseline first-letter-rtc-crash.html #

Patch Set 3 : rebase #

Patch Set 4 : NeedsRebaseline for first-letter-rtc-crash.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -98 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt View 2 chunks +47 lines, -87 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 2 3 1 chunk +24 lines, -10 lines 0 comments Download

Messages

Total messages: 40 (29 generated)
tkent
yosin@, yoichio@, would you review this please? fast/css/first-letter-rtc-crash.html fails on bots. I'll adjust test result ...
3 years, 10 months ago (2017-02-20 08:21:47 UTC) #7
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-20 09:16:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704963002/20001
3 years, 10 months ago (2017-02-20 09:16:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/369747)
3 years, 10 months ago (2017-02-20 10:41:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704963002/20001
3 years, 10 months ago (2017-02-20 13:45:42 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/368527)
3 years, 10 months ago (2017-02-20 13:51:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704963002/40001
3 years, 10 months ago (2017-02-20 15:44:16 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b8c33b2f3b486
3 years, 10 months ago (2017-02-20 15:49:34 UTC) #29
cfroussios
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2708763002/ by cfroussios@chromium.org. ...
3 years, 10 months ago (2017-02-20 17:52:15 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704963002/80001
3 years, 10 months ago (2017-02-20 22:50:53 UTC) #37
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 23:36:57 UTC) #40
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e80226a3b58c969b6a6c8002ce65...

Powered by Google App Engine
This is Rietveld 408576698