|
|
Chromium Code Reviews
DescriptionSelection API: collapseToStart() and collapseToEnd() should recreate a Range.
This CL fixes 46 tests in external/wpt/selection/.
BUG=692400
Review-Url: https://codereview.chromium.org/2704963002
Cr-Original-Commit-Position: refs/heads/master@{#451630}
Committed: https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b8c33b2f3b486
Review-Url: https://codereview.chromium.org/2704963002
Cr-Commit-Position: refs/heads/master@{#451673}
Committed: https://chromium.googlesource.com/chromium/src/+/e80226a3b58c969b6a6c8002ce65bb7e786b96c4
Patch Set 1 #Patch Set 2 : rebaseline first-letter-rtc-crash.html #Patch Set 3 : rebase #Patch Set 4 : NeedsRebaseline for first-letter-rtc-crash.html #
Messages
Total messages: 40 (29 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Selection API: collapseToStart() and collapseToEnd() should recreate a Range. BUG=692400 ========== to ========== Selection API: collapseToStart() and collapseToEnd() should recreate a Range. This CL fixes 46 tests in external/wpt/selection/. BUG=692400 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
tkent@chromium.org changed reviewers: + yoichio@chromium.org, yosin@chromium.org
yosin@, yoichio@, would you review this please? fast/css/first-letter-rtc-crash.html fails on bots. I'll adjust test result later.
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by yosin@chromium.org
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tkent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2704963002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487605441039230,
"parent_rev": "695f49f69873b3678a1233e42349f70882adaf47", "commit_rev":
"716c489b25ad9529994fc83be70b8c33b2f3b486"}
Message was sent while issue was closed.
Description was changed from ========== Selection API: collapseToStart() and collapseToEnd() should recreate a Range. This CL fixes 46 tests in external/wpt/selection/. BUG=692400 ========== to ========== Selection API: collapseToStart() and collapseToEnd() should recreate a Range. This CL fixes 46 tests in external/wpt/selection/. BUG=692400 Review-Url: https://codereview.chromium.org/2704963002 Cr-Commit-Position: refs/heads/master@{#451630} Committed: https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2708763002/ by cfroussios@chromium.org. The reason for reverting is: Suspected cause of failure Test: fast/css/first-letter-rtc-crash.html See bug http://crbug.com/694307.
Patchset #4 (id:60001) has been deleted
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2704963002/#ps80001 (title: "NeedsRebaseline for first-letter-rtc-crash.html")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487631040056570,
"parent_rev": "fb579cdb6aa334f44e57072a3c1fd803aa2cb082", "commit_rev":
"e80226a3b58c969b6a6c8002ce65bb7e786b96c4"}
Message was sent while issue was closed.
Description was changed from ========== Selection API: collapseToStart() and collapseToEnd() should recreate a Range. This CL fixes 46 tests in external/wpt/selection/. BUG=692400 Review-Url: https://codereview.chromium.org/2704963002 Cr-Commit-Position: refs/heads/master@{#451630} Committed: https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b... ========== to ========== Selection API: collapseToStart() and collapseToEnd() should recreate a Range. This CL fixes 46 tests in external/wpt/selection/. BUG=692400 Review-Url: https://codereview.chromium.org/2704963002 Cr-Original-Commit-Position: refs/heads/master@{#451630} Committed: https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b... Review-Url: https://codereview.chromium.org/2704963002 Cr-Commit-Position: refs/heads/master@{#451673} Committed: https://chromium.googlesource.com/chromium/src/+/e80226a3b58c969b6a6c8002ce65... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/e80226a3b58c969b6a6c8002ce65... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
