Reland "Refactor ContentViewClient (4/6)"

Reland "Refactor ContentViewClient (4/6)"

Moved following interface methods to ViewAndroid:
 - onBackgroundColorChanged
 - onTopControlsChanged
 - onBottomControlsChanged
 - onStartContentIntent

Remove following as they are not used:
 - getSystemWindowInsetTop
 - getSystemWindowInsetLeft
 - getSystemWindowInsetRight

Had been reverted due to a bug. https://crrev.com/2694273002/
|Tab.onOffsetChanged| was not updating the offsets as intended.
Fixed it.

BUG=620172, 691718
Review-Url: https://codereview.chromium.org/2708703004
Cr-Commit-Position: refs/heads/master@{#452767}
Committed: https://chromium.googlesource.com/chromium/src/+/e03fba3a51966b99375531dc7250a56deffc808c

[Jinsuk Kim, 2017-02-21 05:43:23]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 05:43:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 08:46:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 08:46:58]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Jinsuk Kim, 2017-02-21 13:52:28]

jinsukkim@chromium.org changed reviewers:
+ boliu@chromium.org, dtrainor@chromium.org

[Jinsuk Kim, 2017-02-21 13:52:29]

dtrainor@chromium.org: Please review changes in chrome/

boliu@chromium.org: Please review changes in content/ ui/

[boliu, 2017-02-21 16:24:28]

can you upload the original patch that got landed, then upload new changes, so
we can review the diff only?

[Jinsuk Kim, 2017-02-21 19:44:40]

On 2017/02/21 16:24:28, boliu wrote:
> can you upload the original patch that got landed, then upload new changes, so
> we can review the diff only?

Done. The diff is
https://codereview.chromium.org/2708703004/diff2/20001:40001/chrome/android/j...

[boliu, 2017-02-21 21:25:50]

diff is in chrome code

just carrying my lgtm from last CL then :)

[Jinsuk Kim, 2017-02-23 01:15:45]

On 2017/02/21 21:25:50, boliu wrote:
> diff is in chrome code
> 
> just carrying my lgtm from last CL then :)

dtrainor@: ping?

[David Trainor- moved to gerrit, 2017-02-24 02:17:35]

lgtm!

https://codereview.chromium.org/2708703004/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2708703004/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:403: bool
FloatEquals(float a, float b) {
Does this method already exist somewhere in Chrome?

[Jinsuk Kim, 2017-02-24 02:32:08]

https://codereview.chromium.org/2708703004/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2708703004/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:403: bool
FloatEquals(float a, float b) {
On 2017/02/24 02:17:34, David Trainor wrote:
> Does this method already exist somewhere in Chrome?

I searched the codebase before for the one I can use in content, but failed to
find any. Many third-party libs have one though.

[Jinsuk Kim, 2017-02-24 04:12:27]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 04:12:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 04:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 04:15:07]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Jinsuk Kim, 2017-02-24 04:40:23]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 04:40:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 05:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 05:43:18]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2017-02-24 05:52:28]

The CQ bit was checked by jinsukkim@chromium.org

[Jinsuk Kim, 2017-02-24 05:52:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2708703004/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-02-24 05:52:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 05:57:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487915548520110,
"parent_rev": "b2b632ce4c039452f4c3158131c50e92381b586d", "commit_rev":
"e03fba3a51966b99375531dc7250a56deffc808c"}

[commit-bot: I haz the power, 2017-02-24 05:57:44]

Description was changed from

==========
Reland "Refactor ContentViewClient (4/6)"

Moved following interface methods to ViewAndroid:
 - onBackgroundColorChanged
 - onTopControlsChanged
 - onBottomControlsChanged
 - onStartContentIntent

Remove following as they are not used:
 - getSystemWindowInsetTop
 - getSystemWindowInsetLeft
 - getSystemWindowInsetRight

Had been reverted due to a bug. https://crrev.com/2694273002/
|Tab.onOffsetChanged| was not updating the offsets as intended.
Fixed it.

BUG=620172, 691718
==========

to

==========
Reland "Refactor ContentViewClient (4/6)"

Moved following interface methods to ViewAndroid:
 - onBackgroundColorChanged
 - onTopControlsChanged
 - onBottomControlsChanged
 - onStartContentIntent

Remove following as they are not used:
 - getSystemWindowInsetTop
 - getSystemWindowInsetLeft
 - getSystemWindowInsetRight

Had been reverted due to a bug. https://crrev.com/2694273002/
|Tab.onOffsetChanged| was not updating the offsets as intended.
Fixed it.

BUG=620172, 691718

Review-Url: https://codereview.chromium.org/2708703004
Cr-Commit-Position: refs/heads/master@{#452767}
Committed:
https://chromium.googlesource.com/chromium/src/+/e03fba3a51966b99375531dc7250...
==========

[commit-bot: I haz the power, 2017-02-24 05:57:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e03fba3a51966b99375531dc7250...