Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2708703004: Reland "Refactor ContentViewClient (4/6)" (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index b1f3ee55cefb65730c389c9ac95152faf0d49e6a..af72e451a617ce1cbfe6d739c5faa76380ad67c7 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -418,8 +418,6 @@ void ContentViewCoreImpl::UpdateFrameInfo(
const gfx::SizeF& viewport_size,
const float top_controls_height,
const float top_controls_shown_ratio,
- const float bottom_controls_height,
- const float bottom_controls_shown_ratio,
bool is_mobile_optimized_hint,
const gfx::SelectionBound& selection_start) {
JNIEnv* env = AttachCurrentThread();
@@ -449,20 +447,11 @@ void ContentViewCoreImpl::UpdateFrameInfo(
page_scale_factor_limits.x(), page_scale_factor_limits.y(),
content_size.width(), content_size.height(), viewport_size.width(),
viewport_size.height(), top_controls_height, top_controls_shown_ratio,
- bottom_controls_height, bottom_controls_shown_ratio,
is_mobile_optimized_hint, has_insertion_marker,
is_insertion_marker_visible, insertion_marker_horizontal,
insertion_marker_top, insertion_marker_bottom);
}
-void ContentViewCoreImpl::OnBackgroundColorChanged(SkColor color) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (obj.is_null())
- return;
- Java_ContentViewCore_onBackgroundColorChanged(env, obj, color);
-}
-
void ContentViewCoreImpl::ShowSelectPopupMenu(
RenderFrameHost* frame,
const gfx::Rect& bounds,
@@ -652,18 +641,6 @@ void ContentViewCoreImpl::ShowPastePopup(int x_dip, int y_dip) {
y_dip);
}
-void ContentViewCoreImpl::StartContentIntent(const GURL& content_url,
- bool is_main_frame) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
- if (j_obj.is_null())
- return;
- ScopedJavaLocalRef<jstring> jcontent_url =
- ConvertUTF8ToJavaString(env, content_url.spec());
- Java_ContentViewCore_startContentIntent(env, j_obj, jcontent_url,
- is_main_frame);
-}
-
void ContentViewCoreImpl::ShowDisambiguationPopup(
const gfx::Rect& rect_pixels,
const SkBitmap& zoomed_bitmap) {
« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698